Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: runtime/vm/service_test.cc

Issue 197763004: I forgot to filter a machine-dependent field in the service unit test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service_test.cc
diff --git a/runtime/vm/service_test.cc b/runtime/vm/service_test.cc
index 7bbd8f71ad875c1fbc84f1e331f9f659b2b58297..01d9d1321e862e0bf2ecc5f7d52f1b0a078ce0df 100644
--- a/runtime/vm/service_test.cc
+++ b/runtime/vm/service_test.cc
@@ -51,7 +51,7 @@ class ServiceTestMessageHandler : public MessageHandler {
old_pos++;
if ((old_len - old_pos) > key_len &&
strncmp(&_msg[old_pos], key, key_len) == 0 &&
- _msg[old_pos + key_len + 2] == '\"') {
+ _msg[old_pos + key_len] == '\"') {
old_pos += (key_len + 2);
// Skip until next , or }.
while (_msg[old_pos] != '\0' &&
@@ -454,11 +454,12 @@ TEST_CASE(Service_Objects) {
Service::HandleIsolateMessage(isolate, service_msg);
handler.HandleNextMessage();
handler.filterMsg("name");
+ handler.filterMsg("size");
EXPECT_STREQ(
"{\"type\":\"String\",\"id\":\"objects\\/1\","
"\"class\":{\"type\":\"@Class\",\"id\":\"classes\\/60\","
"\"user_name\":\"String\"},\"preview\":\"\\\"value\\\"\","
- "\"fields\":[],\"size\":24}",
+ "\"fields\":[],}",
handler.msg());
// object id ring / invalid => expired
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698