Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 197763002: Revert "hide the input method window when the user is done typing" (Closed)

Created:
6 years, 9 months ago by boliu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert "hide the input method window when the user is done typing" Reverting r248903. This is causing keyboard to be erroneously dismissed. See https://code.google.com/p/chromium/issues/detail?id=340100#c14 BUG=340100 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -42 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java View 5 chunks +1 line, -35 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
boliu
+everyone that was involved (I think...)
6 years, 9 months ago (2014-03-12 17:12:23 UTC) #1
jdduke (slow)
On 2014/03/12 17:12:23, boliu wrote: > +everyone that was involved (I think...) lgtm?
6 years, 9 months ago (2014-03-12 17:13:41 UTC) #2
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 9 months ago (2014-03-12 17:14:47 UTC) #3
boliu
The CQ bit was unchecked by boliu@chromium.org
6 years, 9 months ago (2014-03-12 17:14:56 UTC) #4
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 9 months ago (2014-03-12 17:15:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/197763002/1
6 years, 9 months ago (2014-03-12 17:17:54 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 18:24:31 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=160190
6 years, 9 months ago (2014-03-12 18:24:32 UTC) #8
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 9 months ago (2014-03-12 18:36:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/197763002/1
6 years, 9 months ago (2014-03-12 18:37:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/197763002/1
6 years, 9 months ago (2014-03-12 19:32:05 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 05:16:35 UTC) #12
Message was sent while issue was closed.
Change committed as 256750

Powered by Google App Engine
This is Rietveld 408576698