Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2274)

Unified Diff: content/public/browser/resource_request_info.h

Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/render_frame_host.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/resource_request_info.h
diff --git a/content/public/browser/resource_request_info.h b/content/public/browser/resource_request_info.h
index 68c32fbdb947ceb65722687411589b20f12cc7e5..37a8c8ef8fd1fb0af81a4b886154e68b43dc4e64 100644
--- a/content/public/browser/resource_request_info.h
+++ b/content/public/browser/resource_request_info.h
@@ -30,6 +30,12 @@ class ResourceRequestInfo {
// Allocates a new, dummy ResourceRequestInfo and associates it with the
// given URLRequest.
+ //
+ // The RenderView routing ID must correspond to the RenderView of the
+ // RenderFrame, both of which share the same RenderProcess. This may be a
+ // different RenderView than the WebContents' main RenderView. If the
+ // download is not associated with a frame, the IDs can be all -1.
+ //
// NOTE: Add more parameters if you need to initialize other fields.
CONTENT_EXPORT static void AllocateForTesting(net::URLRequest* request,
ResourceType resource_type,
« no previous file with comments | « content/public/browser/render_frame_host.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698