Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: content/browser/download/drag_download_file.cc

Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/drag_download_file.cc
diff --git a/content/browser/download/drag_download_file.cc b/content/browser/download/drag_download_file.cc
index 468c26f5c216a4108a10b0256b11ef4bfdf1ef6d..cd68969fb0dd06ff9cf1ef67f0f4050d72cf3ba7 100644
--- a/content/browser/download/drag_download_file.cc
+++ b/content/browser/download/drag_download_file.cc
@@ -65,8 +65,11 @@ class DragDownloadFile::DragDownloadFileUI : public DownloadItem::Observer {
BrowserContext::GetDownloadManager(web_contents_->GetBrowserContext());
RecordDownloadSource(INITIATED_BY_DRAG_N_DROP);
+ // TODO(https://crbug.com/614134) This should use the frame actually
+ // containing the link being dragged rather than the main frame of the tab.
std::unique_ptr<content::DownloadUrlParameters> params(
- DownloadUrlParameters::FromWebContents(web_contents_, url_));
+ DownloadUrlParameters::CreateForWebContentsMainFrame(
+ web_contents_, url_));
params->set_referrer(referrer_);
params->set_referrer_encoding(referrer_encoding_);
params->set_callback(base::Bind(&DragDownloadFileUI::OnDownloadStarted,
« no previous file with comments | « content/browser/download/download_item_impl.cc ('k') | content/browser/indexed_db/indexed_db_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698