content/browser/android/download_controller_android_impl.cc - Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/download_controller_android_impl.cc

Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | content/browser/download/download_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/download_controller_android_impl.cc

diff --git a/content/browser/android/download_controller_android_impl.cc b/content/browser/android/download_controller_android_impl.cc

index efd07bf2f0e7e52f707a644b97810b510ad761d7..af6b56787ef00719884a0ac72350aef5a27a5ee4 100644

--- a/content/browser/android/download_controller_android_impl.cc

+++ b/content/browser/android/download_controller_android_impl.cc

@@ -81,7 +81,8 @@ void CreateContextMenuDownload(int render_process_id,

content::BrowserContext::GetDownloadManager(

web_contents->GetBrowserContext()));

std::unique_ptr<content::DownloadUrlParameters> dl_params(

- content::DownloadUrlParameters::FromWebContents(web_contents, url));

+ content::DownloadUrlParameters::CreateForWebContentsMainFrame(

+ web_contents, url));

content::Referrer referrer = content::Referrer::SanitizeForRequest(

url,

content::Referrer(referring_url.GetAsReferrer(), params.referrer_policy));