Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: chrome/browser/plugins/plugin_installer.cc

Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_installer.cc
diff --git a/chrome/browser/plugins/plugin_installer.cc b/chrome/browser/plugins/plugin_installer.cc
index 837be684f42102e2512b2126131757a7a14832d7..710ae5dac22f530bdd1d51b4756fad2ba7176e55 100644
--- a/chrome/browser/plugins/plugin_installer.cc
+++ b/chrome/browser/plugins/plugin_installer.cc
@@ -104,8 +104,8 @@ void PluginInstaller::StartInstallingWithDownloadManager(
state_ = INSTALLER_STATE_DOWNLOADING;
FOR_EACH_OBSERVER(PluginInstallerObserver, observers_, DownloadStarted());
std::unique_ptr<content::DownloadUrlParameters> download_parameters(
- content::DownloadUrlParameters::FromWebContents(web_contents,
- plugin_url));
+ content::DownloadUrlParameters::CreateForWebContentsMainFrame(
+ web_contents, plugin_url));
download_parameters->set_callback(
base::Bind(&PluginInstaller::DownloadStarted, base::Unretained(this)));
RecordDownloadSource(DOWNLOAD_INITIATED_BY_PLUGIN_INSTALLER);

Powered by Google App Engine
This is Rietveld 408576698