chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/extensions/api/streams_private/streams_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index 1cc81fea90a1498cc8ebf710ea37328f60a0a38a..5c10000284ab67b7a89e65b18a752bbd322ec1aa 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -965,7 +965,7 @@ bool DownloadsDownloadFunction::RunAsync() {

std::unique_ptr<content::DownloadUrlParameters> download_params(

new content::DownloadUrlParameters(

download_url, render_frame_host()->GetProcess()->GetID(),

- render_view_host_do_not_use()->GetRoutingID(),

+ render_frame_host()->GetRenderViewHost()->GetRoutingID(),

render_frame_host()->GetRoutingID(),

storage_partition->GetURLRequestContext()));