Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3130)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index f838c1e3248d8f2af1cbd45cac0e3182db60602c..343f8d656bc6d422f96314c1c4341fcd02d60ed4 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -883,7 +883,8 @@ class DownloadTest : public InProcessBrowserTest {
creation_observer(new content::DownloadTestItemCreationObserver);
std::unique_ptr<DownloadUrlParameters> params(
- DownloadUrlParameters::FromWebContents(web_contents, starting_url));
+ DownloadUrlParameters::CreateForWebContentsMainFrame(
+ web_contents, starting_url));
params->set_callback(creation_observer->callback());
DownloadManagerForBrowser(browser())->DownloadUrl(std::move(params));
@@ -1680,7 +1681,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, CloseNewTab4) {
// Download a file in that new tab, having it open a file picker
std::unique_ptr<DownloadUrlParameters> params(
- DownloadUrlParameters::FromWebContents(new_tab, slow_download_url));
+ DownloadUrlParameters::CreateForWebContentsMainFrame(
+ new_tab, slow_download_url));
params->set_prompt(true);
manager->DownloadUrl(std::move(params));
observer->WaitForFinished();
@@ -2150,7 +2152,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadUrl) {
DownloadManagerForBrowser(browser()), 1,
content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL));
std::unique_ptr<DownloadUrlParameters> params(
- DownloadUrlParameters::FromWebContents(web_contents, url));
+ DownloadUrlParameters::CreateForWebContentsMainFrame(
+ web_contents, url));
params->set_prompt(true);
DownloadManagerForBrowser(browser())->DownloadUrl(std::move(params));
observer->WaitForFinished();
@@ -2178,7 +2181,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadUrlToPath) {
= other_directory.path().Append(file.BaseName());
content::DownloadTestObserver* observer(CreateWaiter(browser(), 1));
std::unique_ptr<DownloadUrlParameters> params(
- DownloadUrlParameters::FromWebContents(web_contents, url));
+ DownloadUrlParameters::CreateForWebContentsMainFrame(
+ web_contents, url));
params->set_file_path(target_file_full_path);
DownloadManagerForBrowser(browser())->DownloadUrl(std::move(params));
observer->WaitForFinished();
@@ -3634,7 +3638,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTestWithShelf, HiddenDownload) {
WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
std::unique_ptr<DownloadUrlParameters> params(
- DownloadUrlParameters::FromWebContents(web_contents, url));
+ DownloadUrlParameters::CreateForWebContentsMainFrame(
+ web_contents, url));
params->set_callback(base::Bind(&SetHiddenDownloadCallback));
download_manager->DownloadUrl(std::move(params));
observer->WaitForFinished();
« no previous file with comments | « no previous file | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698