chrome/browser/extensions/api/streams_private/streams_private_apitest.cc - Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/streams_private/streams_private_apitest.cc

Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/plugins/plugin_installer.cc » ('j') | content/browser/download/drag_download_file.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/streams_private/streams_private_apitest.cc

diff --git a/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc b/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc

index ab0594ca86facf3cf77eee41e532714ad0d3cf4b..571f464745b65fe2f76ee818d7030009c877c262 100644

--- a/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc

+++ b/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc

@@ -387,7 +387,8 @@ IN_PROC_BROWSER_TEST_F(StreamsPrivateApiTest, DirectDownload) {

browser()->tab_strip_model()->GetActiveWebContents();

ASSERT_TRUE(web_contents);

std::unique_ptr<DownloadUrlParameters> params(

- DownloadUrlParameters::FromWebContents(web_contents, url));

+ DownloadUrlParameters::CreateForWebContentsMainFrame(

+ web_contents, url));

params->set_file_path(target_path);

// Start download of the URL with a path "/text_path.txt" on the test server.