content/browser/download/download_browsertest.cc - Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_browsertest.cc

Issue 1977623002: Updates to DownloadUrlParameters in preparation for OOPIF changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/download_controller_android_impl.cc ('K') | « content/browser/android/download_controller_android_impl.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | content/public/browser/download_url_parameters.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_browsertest.cc

diff --git a/content/browser/download/download_browsertest.cc b/content/browser/download/download_browsertest.cc

index 5d78e1c7a8290d21658c24df3204fde2f14413be..b85abffd83978aa3fdbbf0eb7e5e9b59598fde47 100644

--- a/content/browser/download/download_browsertest.cc

+++ b/content/browser/download/download_browsertest.cc

@@ -2253,8 +2253,8 @@ IN_PROC_BROWSER_TEST_F(DownloadContentTest, CookiePolicy) {

// Download the file.

SetupEnsureNoPendingDownloads();

std::unique_ptr<DownloadUrlParameters> download_parameters(

- DownloadUrlParameters::FromWebContents(shell()->web_contents(),

- origin_two.GetURL("/bar")));

+ DownloadUrlParameters::CreateFromWebContentsMainFrame(

+ shell()->web_contents(), origin_two.GetURL("/bar")));

std::unique_ptr<DownloadTestObserver> observer(CreateWaiter(shell(), 1));

DownloadManagerForShell(shell())->DownloadUrl(std::move(download_parameters));

observer->WaitForFinished();