Updates to DownloadUrlParameters in preparation for OOPIF changes

chrome/browser/renderer_context_menu/render_view_context_menu.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <set>
@@ skipping 81 matching lines @@
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/download_save_info.h"
 #include "content/public/browser/download_url_parameters.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
+#include "content/public/browser/storage_partition.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/browser_plugin_guest_mode.h"
 #include "content/public/common/menu_item.h"
 #include "content/public/common/ssl_status.h"
 #include "content/public/common/url_utils.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
 #include "extensions/browser/view_type_utils.h"
@@ skipping 1622 matching lines @@
 
   return false;
 }
 
 void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
   RenderViewContextMenuBase::ExecuteCommand(id, event_flags);
   if (command_executed_)
     return;
   command_executed_ = true;
 
+  // MAY BE NULL. Check before using. The frame under the cursor could have
+  // been asynchronously destroyed while the context menu was open, but many
+  // context menu commands should continue to function in this situation (e.g.
+  // "Reload").
+  RenderFrameHost* render_frame_host = GetRenderFrameHost();
+
   // Process extension menu items.
   if (ContextMenuMatcher::IsExtensionsCustomCommandId(id)) {
-    extension_items_.ExecuteCommand(id, source_web_contents_,
-                                    GetRenderFrameHost(), params_);
+    if (render_frame_host) {
+      extension_items_.ExecuteCommand(id, source_web_contents_,
+                                      render_frame_host, params_);
+    }
     return;
   }
 
   if (id >= IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST &&
       id <= IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_LAST) {
     ProtocolHandlerRegistry::ProtocolHandlerList handlers =
         GetHandlersForLinkUrl();
     if (handlers.empty())
       return;
 
@@ skipping 54 matching lines @@
               GetDocumentURL(params_),
               NEW_WINDOW,
               ui::PAGE_TRANSITION_LINK);
       break;
 
     case IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD:
       OpenURL(params_.link_url, GURL(), OFF_THE_RECORD,
               ui::PAGE_TRANSITION_LINK);
       break;
 
-    case IDC_CONTENT_CONTEXT_SAVELINKAS: {
-      RecordDownloadSource(DOWNLOAD_INITIATED_BY_CONTEXT_MENU);
-      const GURL& url = params_.link_url;
-      content::Referrer referrer = CreateReferrer(url, params_);
-      DownloadManager* dlm =
-          BrowserContext::GetDownloadManager(browser_context_);
-      std::unique_ptr<DownloadUrlParameters> dl_params(
-          DownloadUrlParameters::FromWebContents(source_web_contents_, url));
-      dl_params->set_referrer(referrer);
-      dl_params->set_referrer_encoding(params_.frame_charset);
-      dl_params->set_suggested_name(params_.suggested_filename);
-      dl_params->set_prompt(true);
-      dlm->DownloadUrl(std::move(dl_params));
+    case IDC_CONTENT_CONTEXT_SAVELINKAS:
+      SaveLinkAs();
       break;
-    }
 
     case IDC_CONTENT_CONTEXT_SAVEAVAS:
     case IDC_CONTENT_CONTEXT_SAVEIMAGEAS: {
       bool is_large_data_url = params_.has_image_contents &&
           params_.src_url.is_empty();
       if (params_.media_type == WebContextMenuData::MediaTypeCanvas ||
           (params_.media_type == WebContextMenuData::MediaTypeImage &&
               is_large_data_url)) {
         source_web_contents_->GetRenderViewHost()->SaveImageAt(
           params_.x, params_.y);
@@ skipping 148 matching lines @@
       DCHECK(platform_app->is_platform_app());
 
       apps::AppLoadService::Get(GetProfile())
           ->RestartApplication(platform_app->id());
       break;
     }
 
     case IDC_PRINT: {
 #if defined(ENABLE_PRINTING)
       if (params_.media_type != WebContextMenuData::MediaTypeNone) {
-        RenderFrameHost* render_frame_host = GetRenderFrameHost();
         if (render_frame_host) {
           render_frame_host->Send(new PrintMsg_PrintNodeUnderContextMenu(
               render_frame_host->GetRoutingID()));
         }
         break;
       }
 
       printing::StartPrint(
           source_web_contents_,
           GetPrefs(browser_context_)->GetBoolean(prefs::kPrintPreviewDisabled),
@@ skipping 246 matching lines @@
 }
 
 void RenderViewContextMenu::Inspect(int x, int y) {
   content::RecordAction(UserMetricsAction("DevTools_InspectElement"));
   RenderFrameHost* render_frame_host = GetRenderFrameHost();
   if (!render_frame_host)
     return;
   DevToolsWindow::InspectElement(render_frame_host, x, y);
 }
 
+void RenderViewContextMenu::SaveLinkAs() {
+  RenderFrameHost* render_frame_host = GetRenderFrameHost();
+  if (!render_frame_host)
+    return;
+
+  RecordDownloadSource(DOWNLOAD_INITIATED_BY_CONTEXT_MENU);
+
+  const GURL& url = params_.link_url;
+  content::StoragePartition* storage_partition =
+      BrowserContext::GetStoragePartition(
+          source_web_contents_->GetBrowserContext(),
+          render_frame_host->GetSiteInstance());
+
+  std::unique_ptr<DownloadUrlParameters> dl_params(
+      new DownloadUrlParameters(
+          url, render_frame_host->GetProcess()->GetID(),
+          render_frame_host->GetRenderViewHost()->GetRoutingID(),
+          render_frame_host->GetRoutingID(),
+          storage_partition->GetURLRequestContext()));
+  dl_params->set_referrer(CreateReferrer(url, params_));
+  dl_params->set_referrer_encoding(params_.frame_charset);
+  dl_params->set_suggested_name(params_.suggested_filename);
+  dl_params->set_prompt(true);
+
+  BrowserContext::GetDownloadManager(browser_context_)->DownloadUrl(
+      std::move(dl_params));
+}
+
 void RenderViewContextMenu::WriteURLToClipboard(const GURL& url) {
   ::WriteURLToClipboard(url);
 }
 
 void RenderViewContextMenu::MediaPlayerActionAt(
     const gfx::Point& location,
     const WebMediaPlayerAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }