Updates to DownloadUrlParameters in preparation for OOPIF changes

content/browser/download/drag_download_file.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/drag_download_file.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/files/file.h"
@@ skipping 48 matching lines @@
   }
 
   void InitiateDownload(base::File file,
                         const base::FilePath& file_path) {
     DCHECK_CURRENTLY_ON(BrowserThread::UI);
     DownloadManager* download_manager =
         BrowserContext::GetDownloadManager(web_contents_->GetBrowserContext());
 
     RecordDownloadSource(INITIATED_BY_DRAG_N_DROP);
     std::unique_ptr<content::DownloadUrlParameters> params(
-        DownloadUrlParameters::FromWebContents(web_contents_, url_));
+        DownloadUrlParameters::CreateForWebContentsMainFrame(

[asanka, 2016/05/13 20:53:41]

This one is also fishy.

[brettw, 2016/05/13 21:20:57]

I thought about this one. I was thinking this was dragging a file to the tab so
it didn't really matter, but on further reflection I think this is dragging a
file out of a tab which I agree sounds wrong.

[asanka, 2016/05/18 15:26:37]

Yeah. This is HTML5 drag & drop. See the "dragging files" example at
http://www.html5rocks.com/en/tutorials/dnd/basics/ .

+            web_contents_, url_));
     params->set_referrer(referrer_);
     params->set_referrer_encoding(referrer_encoding_);
     params->set_callback(base::Bind(&DragDownloadFileUI::OnDownloadStarted,
                                     weak_ptr_factory_.GetWeakPtr()));
     params->set_file_path(file_path);
     params->set_file(std::move(file));  // Nulls file.
     download_manager->DownloadUrl(std::move(params));
   }
 
   void Cancel() {
@@ skipping 161 matching lines @@
 
 void DragDownloadFile::CheckThread() {
 #if defined(OS_WIN)
   DCHECK(drag_message_loop_ == base::MessageLoop::current());
 #else
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 #endif
 }
 
 }  // namespace content