Issue 19776016: Add files. Does not compile yet!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19776016: Add files. Does not compile yet! (Closed)

Created:
7 years, 5 months ago by jamesr

Modified:
7 years, 2 months ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jdduke (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add files. Does not compile yet! BUG=263189

Patch Set 1 #

Patch Set 2 : gtk links, may not work correctly #

Total comments: 1

Patch Set 3 : just gtk #

Patch Set 4 : builders #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+899 lines, -15 lines)			Patch
A	content/browser/renderer_host/input/web_input_event_builders_gtk.h	View	1 2 3	1 chunk	+48 lines, -0 lines	0 comments	Download
A	content/browser/renderer_host/input/web_input_event_builders_gtk.cc	View	1 2 3	1 chunk	+604 lines, -0 lines	0 comments	Download
A	content/browser/renderer_host/input/web_input_event_builders_gtk_unittest.cc	View	1 2 3	1 chunk	+170 lines, -0 lines	0 comments	Download
A	content/browser/renderer_host/input/web_input_event_posix.h	View	1 2 3	1 chunk	+19 lines, -0 lines	0 comments	Download
A	content/browser/renderer_host/input/web_input_event_posix.cc	View	1 2 3	1 chunk	+43 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/native_web_keyboard_event_gtk.cc	View	1 2 3	3 chunks	+5 lines, -7 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_gtk.cc	View	1 2 3	7 chunks	+5 lines, -8 lines	0 comments	Download
M	content/content_browser.gypi	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jamesr

7 years, 5 months ago (2013-07-23 00:04:32 UTC) #1

Message was sent while issue was closed.

https://codereview.chromium.org/19776016/diff/2001/ui/base/keycodes/keyboard_...
File ui/base/keycodes/keyboard_code_conversion.cc (right):

https://codereview.chromium.org/19776016/diff/2001/ui/base/keycodes/keyboard_...
ui/base/keycodes/keyboard_code_conversion.cc:137: return 1 << 11; //
WebInputEvent::IsLeft;
this is clearly not right. we could either:

1.) Move these functions to somewhere that can see WebKit::WebInputEvent, such
as content/browser/renderer_host/something

2.) Add a ui:: enum and convert to the WebInputEvent type in
content/browser/renderer_host/web_input_event_factory_*

3.) ???

Expand Messages | Collapse Messages