Issue 19776006: Fix %NeverOptimizeFunction runtime call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19776006: Fix %NeverOptimizeFunction runtime call. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger

Modified:
7 years, 5 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix %NeverOptimizeFunction runtime call. The current usage of this runtime function is broken as it does not prevent inlining of the affected function but rather bails out from the whole unit of compilation after trying to inline affected functions. This simplifies said runtime function to avoid accidental misuse. R=titzer@chromium.org TEST=mjsunit/never-optimize Committed: http://code.google.com/p/v8/source/detail?r=15762

Patch Set 1 #

Patch Set 2 : Add assert for safety. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -222 lines)			Patch
M	src/hydrogen.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+5 lines, -16 lines	0 comments	Download
M	test/mjsunit/compiler/inline-arguments.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/elements-kind.js	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	test/mjsunit/elide-double-hole-check-9.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/generated-transition-stub.js	View		1 chunk	+172 lines, -168 lines	0 comments	Download
M	test/mjsunit/never-optimize.js	View		2 chunks	+6 lines, -8 lines	0 comments	Download
M	test/mjsunit/opt-elements-kind.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/osr-elements-kind.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/regress/regress-1713b.js	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	test/mjsunit/regress/regress-97116b.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-crbug-173907b.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-deopt-gcb.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/regress/regress-mul-canoverflowb.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 5 months ago (2013-07-19 08:25:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15762 (presubmit successful).

Expand Messages | Collapse Messages