MacViews: add extension install dialog to MacViewsWebUIDialogs

chrome/browser/extensions/extension_install_prompt.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 242 matching lines @@
 
   typedef base::Callback<void(ExtensionInstallPromptShowParams*,
                               const DoneCallback&,
                               std::unique_ptr<ExtensionInstallPrompt::Prompt>)>
       ShowDialogCallback;
 
   // Callback to show the default extension install dialog.
   // The implementations of this function are platform-specific.
   static ShowDialogCallback GetDefaultShowDialogCallback();
 
+  // Callback to show the Views extension install dialog. Don't use this; it is
+  // a temporary hack for MacViews.
+  // TODO(ellyjones): Remove this.
+#if defined(OS_MACOSX)
+  static ShowDialogCallback GetViewsShowDialogCallback();

[tapted, 2016/05/13 07:42:08]

I think it would be nicer to expose this on all platforms -  see below for how
that would work.

(Ideally it would move to
chrome/browser/ui/views/extensions/extension_install_dialog_view.h but DEPS will
complain if extension_install_dialog_controller.mm tries to include that) -

[Elly Fong-Jones, 2016/05/13 21:41:51]

Done.

+#endif
+
   // Returns the appropriate prompt type for the given |extension|.
   // TODO(devlin): This method is yucky - callers probably only care about one
   // prompt type. We just need to comb through and figure out what it is.
   static PromptType GetReEnablePromptTypeForExtension(
       content::BrowserContext* context,
       const extensions::Extension* extension);
 
   // Creates a dummy extension from the |manifest|, replacing the name and
   // description with the localizations if provided.
   static scoped_refptr<extensions::Extension> GetLocalizedExtensionForDisplay(
@@ skipping 106 matching lines @@
 
   // Whether or not the |show_dialog_callback_| was called.
   bool did_call_show_dialog_;
 
   base::WeakPtrFactory<ExtensionInstallPrompt> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionInstallPrompt);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_