Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1977533002: Allow opting out of thumb mode for ARM builds. (Closed)

Created:
4 years, 7 months ago by Dmitry Skiba
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow opting out of thumb mode for ARM builds. Heap profiler relies on frame pointers to do stack unwinding. ARM builds are using thumb mode by default, but since frame pointers are broken in thumb mode for both GCC and LLVM (https://llvm.org/bugs/show_bug.cgi?id=18505), we need a way to build in arm mode. This change exposes arm_use_thumb GN variable so that it can be set to false. BUG=602701 Committed: https://crrev.com/2a91d261e9858e3914153f0fc3d0f57a4b126558 Cr-Commit-Position: refs/heads/master@{#393615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M build/config/arm.gni View 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dmitry Skiba
4 years, 7 months ago (2016-05-12 17:59:49 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-12 18:12:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977533002/1
4 years, 7 months ago (2016-05-13 17:55:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 20:34:09 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 20:35:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a91d261e9858e3914153f0fc3d0f57a4b126558
Cr-Commit-Position: refs/heads/master@{#393615}

Powered by Google App Engine
This is Rietveld 408576698