Issue 1977503005: Remove android vsync service on the Android mojo shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1977503005: Remove android vsync service on the Android mojo shell. (Closed)

Created:
4 years, 7 months ago by qsr

Modified:
4 years, 7 months ago

Reviewers:
nelly, nellyv

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove android vsync service on the Android mojo shell. This service is not used as mozart is already sending vsync information. R=nellyv Committed: https://chromium.googlesource.com/external/mojo/+/a871ea6aeb678b16dd1e8dc8b81d30782a4693df

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -114 lines)			Patch
D	services/vsync/BUILD.gn	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	services/vsync/src/org/chromium/mojo/vsync/VSyncProviderImpl.java	View	1 chunk	+0 lines, -52 lines	0 comments	Download
M	shell/BUILD.gn	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	shell/android/apk/src/org/chromium/mojo/shell/JavaApplicationRegistry.java	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	shell/android/apk/src/org/chromium/mojo/shell/VsyncFactory.java	View	1 chunk	+0 lines, -40 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

qsr

4 years, 7 months ago (2016-05-13 11:48:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a871ea6aeb678b16dd1e8dc8b81d30782a4693df (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages