Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Side by Side Diff: src/effects/SkBlurImageFilter.cpp

Issue 19775006: Implement crop rect for SkImageFilter (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Revert more unnecessary changes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright 2011 The Android Open Source Project 2 * Copyright 2011 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBitmap.h" 8 #include "SkBitmap.h"
9 #include "SkBlurImageFilter.h" 9 #include "SkBlurImageFilter.h"
10 #include "SkColorPriv.h" 10 #include "SkColorPriv.h"
11 #include "SkFlattenableBuffers.h" 11 #include "SkFlattenableBuffers.h"
12 #include "SkGpuBlurUtils.h" 12 #include "SkGpuBlurUtils.h"
13 #if SK_SUPPORT_GPU 13 #if SK_SUPPORT_GPU
14 #include "GrContext.h" 14 #include "GrContext.h"
15 #include "SkImageFilterUtils.h" 15 #include "SkImageFilterUtils.h"
16 #endif 16 #endif
17 17
18 SkBlurImageFilter::SkBlurImageFilter(SkFlattenableReadBuffer& buffer) 18 SkBlurImageFilter::SkBlurImageFilter(SkFlattenableReadBuffer& buffer)
19 : INHERITED(buffer) { 19 : INHERITED(buffer) {
20 fSigma.fWidth = buffer.readScalar(); 20 fSigma.fWidth = buffer.readScalar();
21 fSigma.fHeight = buffer.readScalar(); 21 fSigma.fHeight = buffer.readScalar();
22 } 22 }
23 23
24 SkBlurImageFilter::SkBlurImageFilter(SkScalar sigmaX, SkScalar sigmaY, SkImageFi lter* input) 24 SkBlurImageFilter::SkBlurImageFilter(SkScalar sigmaX, SkScalar sigmaY, SkImageFi lter* input, const SkIRect* cropRect)
reed1 2013/07/19 21:34:04 line-wrap
25 : INHERITED(input), fSigma(SkSize::Make(sigmaX, sigmaY)) { 25 : INHERITED(input, cropRect), fSigma(SkSize::Make(sigmaX, sigmaY)) {
26 SkASSERT(sigmaX >= 0 && sigmaY >= 0); 26 SkASSERT(sigmaX >= 0 && sigmaY >= 0);
27 } 27 }
28 28
29 void SkBlurImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const { 29 void SkBlurImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {
30 this->INHERITED::flatten(buffer); 30 this->INHERITED::flatten(buffer);
31 buffer.writeScalar(fSigma.fWidth); 31 buffer.writeScalar(fSigma.fWidth);
32 buffer.writeScalar(fSigma.fHeight); 32 buffer.writeScalar(fSigma.fHeight);
33 } 33 }
34 34
35 static void boxBlurX(const SkBitmap& src, SkBitmap* dst, int kernelSize, 35 static void boxBlurX(const SkBitmap& src, SkBitmap* dst, int kernelSize,
36 int leftOffset, int rightOffset) 36 int leftOffset, int rightOffset, const SkIRect& bounds)
37 { 37 {
38 int width = src.width(), height = src.height(); 38 int width = bounds.width(), height = bounds.height();
39 int rightBorder = SkMin32(rightOffset + 1, width); 39 int rightBorder = SkMin32(rightOffset + 1, width);
40 for (int y = 0; y < height; ++y) { 40 for (int y = 0; y < height; ++y) {
41 int sumA = 0, sumR = 0, sumG = 0, sumB = 0; 41 int sumA = 0, sumR = 0, sumG = 0, sumB = 0;
42 SkPMColor* p = src.getAddr32(0, y); 42 SkPMColor* p = src.getAddr32(bounds.fLeft, y + bounds.fTop);
43 for (int i = 0; i < rightBorder; ++i) { 43 for (int i = 0; i < rightBorder; ++i) {
44 sumA += SkGetPackedA32(*p); 44 sumA += SkGetPackedA32(*p);
45 sumR += SkGetPackedR32(*p); 45 sumR += SkGetPackedR32(*p);
46 sumG += SkGetPackedG32(*p); 46 sumG += SkGetPackedG32(*p);
47 sumB += SkGetPackedB32(*p); 47 sumB += SkGetPackedB32(*p);
48 p++; 48 p++;
49 } 49 }
50 50
51 const SkColor* sptr = src.getAddr32(0, y); 51 const SkColor* sptr = src.getAddr32(bounds.fLeft, bounds.fTop + y);
52 SkColor* dptr = dst->getAddr32(0, y); 52 SkColor* dptr = dst->getAddr32(0, y);
53 for (int x = 0; x < width; ++x) { 53 for (int x = 0; x < width; ++x) {
54 *dptr = SkPackARGB32(sumA / kernelSize, 54 *dptr = SkPackARGB32(sumA / kernelSize,
55 sumR / kernelSize, 55 sumR / kernelSize,
56 sumG / kernelSize, 56 sumG / kernelSize,
57 sumB / kernelSize); 57 sumB / kernelSize);
58 if (x >= leftOffset) { 58 if (x >= leftOffset) {
59 SkColor l = *(sptr - leftOffset); 59 SkColor l = *(sptr - leftOffset);
60 sumA -= SkGetPackedA32(l); 60 sumA -= SkGetPackedA32(l);
61 sumR -= SkGetPackedR32(l); 61 sumR -= SkGetPackedR32(l);
62 sumG -= SkGetPackedG32(l); 62 sumG -= SkGetPackedG32(l);
63 sumB -= SkGetPackedB32(l); 63 sumB -= SkGetPackedB32(l);
64 } 64 }
65 if (x + rightOffset + 1 < width) { 65 if (x + rightOffset + 1 < width) {
66 SkColor r = *(sptr + rightOffset + 1); 66 SkColor r = *(sptr + rightOffset + 1);
67 sumA += SkGetPackedA32(r); 67 sumA += SkGetPackedA32(r);
68 sumR += SkGetPackedR32(r); 68 sumR += SkGetPackedR32(r);
69 sumG += SkGetPackedG32(r); 69 sumG += SkGetPackedG32(r);
70 sumB += SkGetPackedB32(r); 70 sumB += SkGetPackedB32(r);
71 } 71 }
72 sptr++; 72 sptr++;
73 dptr++; 73 dptr++;
74 } 74 }
75 } 75 }
76 } 76 }
77 77
78 static void boxBlurY(const SkBitmap& src, SkBitmap* dst, int kernelSize, 78 static void boxBlurY(const SkBitmap& src, SkBitmap* dst, int kernelSize,
79 int topOffset, int bottomOffset) 79 int topOffset, int bottomOffset, const SkIRect& bounds)
80 { 80 {
81 int width = src.width(), height = src.height(); 81 int width = bounds.width(), height = bounds.height();
82 int bottomBorder = SkMin32(bottomOffset + 1, height); 82 int bottomBorder = SkMin32(bottomOffset + 1, height);
83 int srcStride = src.rowBytesAsPixels(); 83 int srcStride = src.rowBytesAsPixels();
84 int dstStride = dst->rowBytesAsPixels(); 84 int dstStride = dst->rowBytesAsPixels();
85 for (int x = 0; x < width; ++x) { 85 for (int x = 0; x < width; ++x) {
86 int sumA = 0, sumR = 0, sumG = 0, sumB = 0; 86 int sumA = 0, sumR = 0, sumG = 0, sumB = 0;
87 SkColor* p = src.getAddr32(x, 0); 87 SkColor* p = src.getAddr32(bounds.fLeft + x, bounds.fTop);
88 for (int i = 0; i < bottomBorder; ++i) { 88 for (int i = 0; i < bottomBorder; ++i) {
89 sumA += SkGetPackedA32(*p); 89 sumA += SkGetPackedA32(*p);
90 sumR += SkGetPackedR32(*p); 90 sumR += SkGetPackedR32(*p);
91 sumG += SkGetPackedG32(*p); 91 sumG += SkGetPackedG32(*p);
92 sumB += SkGetPackedB32(*p); 92 sumB += SkGetPackedB32(*p);
93 p += srcStride; 93 p += srcStride;
94 } 94 }
95 95
96 const SkColor* sptr = src.getAddr32(x, 0); 96 const SkColor* sptr = src.getAddr32(bounds.fLeft + x, bounds.fTop);
97 SkColor* dptr = dst->getAddr32(x, 0); 97 SkColor* dptr = dst->getAddr32(x, 0);
98 for (int y = 0; y < height; ++y) { 98 for (int y = 0; y < height; ++y) {
99 *dptr = SkPackARGB32(sumA / kernelSize, 99 *dptr = SkPackARGB32(sumA / kernelSize,
100 sumR / kernelSize, 100 sumR / kernelSize,
101 sumG / kernelSize, 101 sumG / kernelSize,
102 sumB / kernelSize); 102 sumB / kernelSize);
103 if (y >= topOffset) { 103 if (y >= topOffset) {
104 SkColor l = *(sptr - topOffset * srcStride); 104 SkColor l = *(sptr - topOffset * srcStride);
105 sumA -= SkGetPackedA32(l); 105 sumA -= SkGetPackedA32(l);
106 sumR -= SkGetPackedR32(l); 106 sumR -= SkGetPackedR32(l);
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 } 145 }
146 146
147 if (src.config() != SkBitmap::kARGB_8888_Config) { 147 if (src.config() != SkBitmap::kARGB_8888_Config) {
148 return false; 148 return false;
149 } 149 }
150 150
151 SkAutoLockPixels alp(src); 151 SkAutoLockPixels alp(src);
152 if (!src.getPixels()) { 152 if (!src.getPixels()) {
153 return false; 153 return false;
154 } 154 }
155 155
156 dst->setConfig(src.config(), src.width(), src.height()); 156 SkIRect srcBounds, dstBounds;
157 src.getBounds(&srcBounds);
158 applyCropRect(&srcBounds);
159 dst->setConfig(src.config(), srcBounds.width(), srcBounds.height());
160 dst->getBounds(&dstBounds);
157 dst->allocPixels(); 161 dst->allocPixels();
158 int kernelSizeX, kernelSizeX3, lowOffsetX, highOffsetX; 162 int kernelSizeX, kernelSizeX3, lowOffsetX, highOffsetX;
159 int kernelSizeY, kernelSizeY3, lowOffsetY, highOffsetY; 163 int kernelSizeY, kernelSizeY3, lowOffsetY, highOffsetY;
160 getBox3Params(fSigma.width(), &kernelSizeX, &kernelSizeX3, &lowOffsetX, &hig hOffsetX); 164 getBox3Params(fSigma.width(), &kernelSizeX, &kernelSizeX3, &lowOffsetX, &hig hOffsetX);
161 getBox3Params(fSigma.height(), &kernelSizeY, &kernelSizeY3, &lowOffsetY, &hi ghOffsetY); 165 getBox3Params(fSigma.height(), &kernelSizeY, &kernelSizeY3, &lowOffsetY, &hi ghOffsetY);
162 166
163 if (kernelSizeX < 0 || kernelSizeY < 0) { 167 if (kernelSizeX < 0 || kernelSizeY < 0) {
164 return false; 168 return false;
165 } 169 }
166 170
167 if (kernelSizeX == 0 && kernelSizeY == 0) { 171 if (kernelSizeX == 0 && kernelSizeY == 0) {
168 src.copyTo(dst, dst->config()); 172 src.copyTo(dst, dst->config());
169 return true; 173 return true;
170 } 174 }
171 175
172 SkBitmap temp; 176 SkBitmap temp;
173 temp.setConfig(dst->config(), dst->width(), dst->height()); 177 temp.setConfig(dst->config(), dst->width(), dst->height());
174 if (!temp.allocPixels()) { 178 if (!temp.allocPixels()) {
175 return false; 179 return false;
176 } 180 }
177 181
178 if (kernelSizeX > 0 && kernelSizeY > 0) { 182 if (kernelSizeX > 0 && kernelSizeY > 0) {
179 boxBlurX(src, &temp, kernelSizeX, lowOffsetX, highOffsetX); 183 boxBlurX(src, &temp, kernelSizeX, lowOffsetX, highOffsetX, srcBounds) ;
180 boxBlurY(temp, dst, kernelSizeY, lowOffsetY, highOffsetY); 184 boxBlurY(temp, dst, kernelSizeY, lowOffsetY, highOffsetY, dstBounds) ;
181 boxBlurX(*dst, &temp, kernelSizeX, highOffsetX, lowOffsetX); 185 boxBlurX(*dst, &temp, kernelSizeX, highOffsetX, lowOffsetX, dstBounds);
182 boxBlurY(temp, dst, kernelSizeY, highOffsetY, lowOffsetY); 186 boxBlurY(temp, dst, kernelSizeY, highOffsetY, lowOffsetY, dstBounds);
183 boxBlurX(*dst, &temp, kernelSizeX3, highOffsetX, highOffsetX); 187 boxBlurX(*dst, &temp, kernelSizeX3, highOffsetX, highOffsetX, dstBounds) ;
184 boxBlurY(temp, dst, kernelSizeY3, highOffsetY, highOffsetY); 188 boxBlurY(temp, dst, kernelSizeY3, highOffsetY, highOffsetY, dstBounds) ;
185 } else if (kernelSizeX > 0) { 189 } else if (kernelSizeX > 0) {
186 boxBlurX(src, dst, kernelSizeX, lowOffsetX, highOffsetX); 190 boxBlurX(src, dst, kernelSizeX, lowOffsetX, highOffsetX, srcBounds) ;
187 boxBlurX(*dst, &temp, kernelSizeX, highOffsetX, lowOffsetX); 191 boxBlurX(*dst, &temp, kernelSizeX, highOffsetX, lowOffsetX, dstBounds);
188 boxBlurX(temp, dst, kernelSizeX3, highOffsetX, highOffsetX); 192 boxBlurX(temp, dst, kernelSizeX3, highOffsetX, highOffsetX, dstBounds) ;
189 } else if (kernelSizeY > 0) { 193 } else if (kernelSizeY > 0) {
190 boxBlurY(src, dst, kernelSizeY, lowOffsetY, highOffsetY); 194 boxBlurY(src, dst, kernelSizeY, lowOffsetY, highOffsetY, srcBounds) ;
191 boxBlurY(*dst, &temp, kernelSizeY, highOffsetY, lowOffsetY); 195 boxBlurY(*dst, &temp, kernelSizeY, highOffsetY, lowOffsetY, dstBounds);
192 boxBlurY(temp, dst, kernelSizeY3, highOffsetY, highOffsetY); 196 boxBlurY(temp, dst, kernelSizeY3, highOffsetY, highOffsetY, dstBounds) ;
193 } 197 }
198 offset->fX += srcBounds.fLeft;
199 offset->fY += srcBounds.fTop;
194 return true; 200 return true;
195 } 201 }
196 202
197 bool SkBlurImageFilter::filterImageGPU(Proxy* proxy, const SkBitmap& src, SkBitm ap* result, 203 bool SkBlurImageFilter::filterImageGPU(Proxy* proxy, const SkBitmap& src, SkBitm ap* result,
198 SkIPoint* offset) { 204 SkIPoint* offset) {
199 #if SK_SUPPORT_GPU 205 #if SK_SUPPORT_GPU
200 SkBitmap input; 206 SkBitmap input;
201 if (!SkImageFilterUtils::GetInputResultGPU(getInput(0), proxy, src, &input, offset)) { 207 if (!SkImageFilterUtils::GetInputResultGPU(getInput(0), proxy, src, &input, offset)) {
202 return false; 208 return false;
203 } 209 }
204 GrTexture* source = input.getTexture(); 210 GrTexture* source = input.getTexture();
205 SkRect rect; 211 SkIRect rect;
206 src.getBounds(&rect); 212 src.getBounds(&rect);
207 SkAutoTUnref<GrTexture> tex(SkGpuBlurUtils::GaussianBlur(source->getContext( ), 213 applyCropRect(&rect);
208 source, false, rect , 214 SkAutoTUnref<GrTexture> tex(SkGpuBlurUtils::GaussianBlur(source->getContext( ),
215 source, false, SkRe ct::Make(rect),
209 fSigma.width(), fSi gma.height())); 216 fSigma.width(), fSi gma.height()));
210 return SkImageFilterUtils::WrapTexture(tex, src.width(), src.height(), resul t); 217 offset->fX += rect.fLeft;
218 offset->fY += rect.fTop;
219 return SkImageFilterUtils::WrapTexture(tex, rect.width(), rect.height(), res ult);
211 #else 220 #else
212 SkDEBUGFAIL("Should not call in GPU-less build"); 221 SkDEBUGFAIL("Should not call in GPU-less build");
213 return false; 222 return false;
214 #endif 223 #endif
215 } 224 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698