[mojo-edk] Add sanity checks to NodeChannel inputs

[mojo-edk] Add sanity checks to NodeChannel inputs

Prevents reading memory beyond the bounds of a
received NodeChannel message.

BUG=611887
Committed: https://crrev.com/10eebb639c2ca8d062ce9c3623f2b7bd67dd9f4c
Cr-Commit-Position: refs/heads/master@{#393713}

[Ken Rockot(use gerrit already), 2016-05-13 23:12:08]

rockot@chromium.org changed reviewers:
+ ochang@chromium.org

[Ken Rockot(use gerrit already), 2016-05-13 23:12:09]

Not addressing everything, but I think this covers the NodeChannel layer.

[Oliver Chang, 2016-05-13 23:32:44]

thanks for the quick patch!

LGTM with a question.

https://codereview.chromium.org/1977493004/diff/1/mojo/edk/system/node_channe...
File mojo/edk/system/node_channel.cc (right):

https://codereview.chromium.org/1977493004/diff/1/mojo/edk/system/node_channe...
mojo/edk/system/node_channel.cc:540: std::string token(token_data, token_size);
does it make sense for token_size to be 0 here?

[Ken Rockot(use gerrit already), 2016-05-13 23:38:40]

Thanks!

On 2016/05/13 at 23:32:44, ochang wrote:
> thanks for the quick patch!
> 
> LGTM with a question.
> 
>
https://codereview.chromium.org/1977493004/diff/1/mojo/edk/system/node_channe...
> File mojo/edk/system/node_channel.cc (right):
> 
>
https://codereview.chromium.org/1977493004/diff/1/mojo/edk/system/node_channe...
> mojo/edk/system/node_channel.cc:540: std::string token(token_data,
token_size);
> does it make sense for token_size to be 0 here?

Nope, good catch. This is now also prevented.

[Ken Rockot(use gerrit already), 2016-05-13 23:38:49]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-05-13 23:38:50]

The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org
Link to the patchset: https://codereview.chromium.org/1977493004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-13 23:39:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977493004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977493004/20001

[commit-bot: I haz the power, 2016-05-14 00:53:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-14 00:54:38]

Description was changed from

==========
[mojo-edk] Add sanity checks to NodeChannel inputs

Prevents reading memory beyond the bounds of a
received NodeChannel message.

BUG=611887
==========

to

==========
[mojo-edk] Add sanity checks to NodeChannel inputs

Prevents reading memory beyond the bounds of a
received NodeChannel message.

BUG=611887

Committed: https://crrev.com/10eebb639c2ca8d062ce9c3623f2b7bd67dd9f4c
Cr-Commit-Position: refs/heads/master@{#393713}
==========

[commit-bot: I haz the power, 2016-05-14 00:54:39]

Patchset 2 (id:??) landed as
https://crrev.com/10eebb639c2ca8d062ce9c3623f2b7bd67dd9f4c
Cr-Commit-Position: refs/heads/master@{#393713}