Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1977473003:
ServiceWorker: Remove a bad IPC message check on postMessage() (Closed)
|
Created:
4 years, 7 months ago by nhiroki Modified:
4 years, 7 months ago Reviewers:
falken CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionServiceWorker: Remove a bad IPC message check on postMessage()
This CL removes a bad IPC message check to confirm existence of the sender
provder host on postMessage() because the provider host may be destroyed before
this point when destruction of the provider overtakes postMessage() during
thread hopping on WebServiceWorkerImpl::postMessage().
BUG=608464
Committed: https://crrev.com/66525f41fc6509604c61a8c0304141662cbdbe97
Cr-Commit-Position: refs/heads/master@{#393495}
Patch Set 1 : #
Messages
Total messages: 14 (9 generated)
Description was changed from ========== ServiceWorker: Remove a bad IPC message check for postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because it may validly occur when destruction of the sender provider overtakes an IPC message for postMessage() during thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ========== to ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before the point when destruction of the provider overtakes an IPC message for postMessage() during thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ==========
Description was changed from ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before the point when destruction of the provider overtakes an IPC message for postMessage() during thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ========== to ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before the point when destruction of the provider overtakes an IPC message for postMessage() during thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ==========
Description was changed from ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before the point when destruction of the provider overtakes an IPC message for postMessage() during thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ========== to ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before the point when destruction of the provider overtakes an IPC message for postMessage() because of thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ==========
nhiroki@chromium.org changed reviewers: + falken@chromium.org
Description was changed from ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before the point when destruction of the provider overtakes an IPC message for postMessage() because of thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ========== to ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before this point when destruction of the provider overtakes postMessage() during thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ==========
Description was changed from ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before this point when destruction of the provider overtakes postMessage() during thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ========== to ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before this point when destruction of the provider overtakes postMessage() during thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ==========
Patchset #1 (id:1) has been deleted
ptal, thanks!
lgtm
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977473003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977473003/20001
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before this point when destruction of the provider overtakes postMessage() during thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 ========== to ========== ServiceWorker: Remove a bad IPC message check on postMessage() This CL removes a bad IPC message check to confirm existence of the sender provder host on postMessage() because the provider host may be destroyed before this point when destruction of the provider overtakes postMessage() during thread hopping on WebServiceWorkerImpl::postMessage(). BUG=608464 Committed: https://crrev.com/66525f41fc6509604c61a8c0304141662cbdbe97 Cr-Commit-Position: refs/heads/master@{#393495} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/66525f41fc6509604c61a8c0304141662cbdbe97 Cr-Commit-Position: refs/heads/master@{#393495} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
