Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1977433002: [compiler] Remove explicit live edit check for lazy compilation (Closed)

Created:
4 years, 7 months ago by jgruber1
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove explicit live edit check for lazy compilation Any function that is being compiled for live edit is marked as debug. R=yangguo@chromium.org BUG= Committed: https://crrev.com/4548df88a375cca3e2ec038deb2946aadbe704af Cr-Commit-Position: refs/heads/master@{#36205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977433002/1
4 years, 7 months ago (2016-05-12 10:48:22 UTC) #2
jgruber1
4 years, 7 months ago (2016-05-12 10:54:28 UTC) #3
Yang
On 2016/05/12 10:54:28, jgruber wrote: LGTM.
4 years, 7 months ago (2016-05-12 10:58:18 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 11:19:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977433002/1
4 years, 7 months ago (2016-05-12 11:22:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 11:25:20 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 11:27:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4548df88a375cca3e2ec038deb2946aadbe704af
Cr-Commit-Position: refs/heads/master@{#36205}

Powered by Google App Engine
This is Rietveld 408576698