chrome/browser/push_messaging/push_messaging_notification_manager.h - Issue 1977423002: Added UMA stats to track the budget for any service worker which receives a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_notification_manager.h

Issue 1977423002: Added UMA stats to track the budget for any service worker which receives a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Post-rebase include fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | chrome/browser/push_messaging/push_messaging_notification_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_notification_manager.h

diff --git a/chrome/browser/push_messaging/push_messaging_notification_manager.h b/chrome/browser/push_messaging/push_messaging_notification_manager.h

index 736d91b654bb44694a89ebfc56a5f7e14a9c98ff..60a2edb78d70cbec4412ac0207cf14054751f412 100644

--- a/chrome/browser/push_messaging/push_messaging_notification_manager.h

+++ b/chrome/browser/push_messaging/push_messaging_notification_manager.h

@@ -73,10 +73,10 @@ class PushMessagingNotificationManager {

content::WebContents* active_web_contents,

const GURL& origin);

- void DidGetBudget(const GURL& origin,

- int64_t service_worker_registration_id,

- const base::Closure& message_handled_closure,

- const double budget);

+ void CheckForMissedNotification(const GURL& origin,

+ int64_t service_worker_registration_id,

+ const base::Closure& message_handled_closure,

+ const double budget);

static void DidWriteNotificationDataIOProxy(

const base::WeakPtr<PushMessagingNotificationManager>& ui_weak_ptr,