tools/metrics/histograms/histograms.xml - Issue 1977423002: Added UMA stats to track the budget for any service worker which receives a

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1977423002: Added UMA stats to track the budget for any service worker which receives a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added NOTREACHED and nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/browser/push_messaging/push_messaging_notification_manager.cc ('K') | « chrome/browser/push_messaging/push_messaging_notification_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 277aae703bb89c4c4397c61b8a7c5b0f3bd2f556..d8e8074956a084d1fbc8179147bd47c93b5f3e90 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -42371,6 +42371,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PushMessaging.BackgroundBudget">

Alexei Svitkine (slow) 2016/05/18 15:10:57 Please add units= attribute for these. What units

harkness 2016/05/18 16:18:35 Unfortunately, it's just in "units". It's an inter

+ <owner>harkness@chromium.org</owner>

+ <summary>

+ Whenever a Service Worker receives a push message, this records the budget

+ available to the service worker.

Alexei Svitkine (slow) 2016/05/18 15:10:57 What does budget mean? Please explain.

harkness 2016/05/18 16:18:35 I updated the description with additional informat

+ </summary>

+</histogram>

<owner>johnme@google.com</owner>

<owner>mvanouwerkerk@google.com</owner>

@@ -42401,6 +42409,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PushMessaging.SESForLowBudgetOrigin">

+ <owner>harkness@chromium.org</owner>

+ <summary>

+ When a Service Worker hits low budget when servicing a push message, this

+ records what the Site Engagement Service score is at that time.

+ </summary>

+</histogram>

+<histogram name="PushMessaging.SESForNoBudgetOrigin">

+ <owner>harkness@chromium.org</owner>

+ <summary>

+ When a Service Worker hits zero budget when servicing a push message, this

+ records what the Site Engagement Service score is at that time.

+ </summary>

+</histogram>

<histogram name="PushMessaging.UnregistrationStatus"

enum="PushUnregistrationStatus">

<owner>johnme@google.com</owner>