Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1977413002: Improve type information and minor clean up (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -44 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/dart/element/element.dart View 5 chunks +17 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/source/config.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/source/error_processor.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/services/lint.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-05-16 15:23:58 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-16 15:26:25 UTC) #3
Brian Wilkerson
4 years, 7 months ago (2016-05-16 15:43:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3024554b3cb72977f3b4d1d3adf4df1a3dd1d1c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698