tools/telemetry/telemetry/core/tab_unittest.py - Issue 19774009: Fix for extension binding race condition when evaluating JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/tab_unittest.py

Issue 19774009: Fix for extension binding race condition when evaluating JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tab unit tests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('K') | « tools/telemetry/telemetry/core/extension_unittest.py ('k') | tools/telemetry/telemetry/unittest/tab_test_case.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/tab_unittest.py

diff --git a/tools/telemetry/telemetry/core/tab_unittest.py b/tools/telemetry/telemetry/core/tab_unittest.py

index f555dc2812745a06c927cc1517a102b31bfcc07b..3bc3089104cdbb171d09cea3fb34bfa45b53e596 100644

--- a/tools/telemetry/telemetry/core/tab_unittest.py

+++ b/tools/telemetry/telemetry/core/tab_unittest.py

@@ -44,6 +44,7 @@ class TabTest(tab_test_case.TabTestCase):

self.assertTrue(_IsDocumentVisible(self._tab))

new_tab = self._browser.tabs.New()

+ new_tab.Navigate('about:blank')

util.WaitFor(lambda: _IsDocumentVisible(new_tab), timeout=5)

self.assertFalse(_IsDocumentVisible(self._tab))

self._tab.Activate()