tools/telemetry/telemetry/core/backends/chrome/extension_dict_backend.py - Issue 19774009: Fix for extension binding race condition when evaluating JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/extension_dict_backend.py

Issue 19774009: Fix for extension binding race condition when evaluating JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tab unit tests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('K') | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/inspector_page.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/extension_dict_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/extension_dict_backend.py b/tools/telemetry/telemetry/core/backends/chrome/extension_dict_backend.py

index 40e76d021da22d992ad58bb20fa942d07096dc08..b45bb6ccc81f8ad362a84853d106a73459c5a1ce 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/extension_dict_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/extension_dict_backend.py

@@ -45,6 +45,8 @@ class ExtensionDictBackend(object):

if not extension_info or not 'webSocketDebuggerUrl' in extension_info:

raise ExtensionNotFoundException()

return extension_page.ExtensionPage(

+ extension_id,

+ extension_info['url'],

self._CreateInspectorBackendForDebuggerUrl(

extension_info['webSocketDebuggerUrl']))