Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: recipe_modules/gclient/example.py

Issue 1977373002: Fix revision for WebRTC patches sent to Chromium trybots (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Added test case for coverage Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: recipe_modules/gclient/example.py
diff --git a/recipe_modules/gclient/example.py b/recipe_modules/gclient/example.py
index fa6daf8950862ab8c919bf525932360496efa0a9..bff97dc4332f6a04e659aaf339e789573a791c9f 100644
--- a/recipe_modules/gclient/example.py
+++ b/recipe_modules/gclient/example.py
@@ -91,6 +91,11 @@ def RunSteps(api):
assert not api.gclient.is_blink_mode
+ if api.properties.get('patch_project'):
+ api.gclient.set_patch_project_revision(
+ patch_project=api.properties.get('patch_project'),
+ gclient_config=api.gclient.make_config('chromium_bare'))
tandrii(chromium) 2016/05/16 20:33:48 sadly this call doesn't add anything to expectatio
kjellander_chromium 2016/05/16 20:41:44 Right, it's just here for coverage.
+
def GenTests(api):
yield api.test('basic')
@@ -98,3 +103,9 @@ def GenTests(api):
yield api.test('revision') + api.properties(revision='abc')
yield api.test('tryserver') + api.properties.tryserver()
+
+ yield (
+ api.test('tryserver_webrtc_patch') +
+ api.properties.tryserver() +
+ api.properties(patch_project='webrtc')
tandrii(chromium) 2016/05/16 20:33:48 nit: these kwargs can be inside .tryserver() above
kjellander_chromium 2016/05/16 20:41:44 Done.
+ )
« no previous file with comments | « recipe_modules/gclient/config.py ('k') | recipe_modules/gclient/example.expected/tryserver_webrtc_patch.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698