Fix revision for WebRTC patches sent to Chromium trybots

Fix revision for WebRTC patches sent to Chromium trybots

This will have the revision set properly to 'HEAD' before attempting
to apply the patch.
It should also solve the problem that analyze is ending up with
no changes when running 'git diff'.

Expectation update in: https://codereview.chromium.org/1984673002

BUG=438952
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300603

[kjellander_chromium, 2016-05-16 14:47:58]

Description was changed from

==========
Fix revision for WebRTC patches sent to Chromium trybots

This will have the revision set properly to 'HEAD' before attempting
to apply the patch. It should also solve the problem that analyze
is ending up with no changes when running 'git diff'.

BUG=438952
==========

to

==========
Fix revision for WebRTC patches sent to Chromium trybots

This will have the revision set properly to 'HEAD' before attempting
to apply the patch.
It should also solve the problem that analyze is ending up with
no changes when running 'git diff'.

BUG=438952
==========

[kjellander_chromium, 2016-05-16 14:47:58]

kjellander@chromium.org changed reviewers:
+ tandrii@chromium.org

[kjellander_chromium, 2016-05-16 14:48:12]

Description was changed from

==========
Fix revision for WebRTC patches sent to Chromium trybots

This will have the revision set properly to 'HEAD' before attempting
to apply the patch.
It should also solve the problem that analyze is ending up with
no changes when running 'git diff'.

BUG=438952
==========

to

==========
Fix revision for WebRTC patches sent to Chromium trybots

This will have the revision set properly to 'HEAD' before attempting
to apply the patch.
It should also solve the problem that analyze is ending up with
no changes when running 'git diff'.

Expectation update in: https://codereview.chromium.org/1984673002

BUG=438952
==========

[kjellander_chromium, 2016-05-16 14:48:19]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-16 14:48:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977373002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977373002/1

[commit-bot: I haz the power, 2016-05-16 16:10:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 16:10:50]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[tandrii(chromium), 2016-05-16 17:06:59]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-05-16 17:07:00]

lgtm

[commit-bot: I haz the power, 2016-05-16 17:07:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977373002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977373002/1

[commit-bot: I haz the power, 2016-05-16 17:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 17:52:17]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[tandrii(chromium), 2016-05-16 17:53:36]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2016-05-16 17:56:02]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-05-16 17:56:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977373002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977373002/1

[commit-bot: I haz the power, 2016-05-16 18:01:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 18:01:49]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[kjellander_chromium, 2016-05-16 19:43:49]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-16 19:43:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977373002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977373002/20001

[kjellander_chromium, 2016-05-16 19:44:44]

PTAL after adding coverage test case.

[commit-bot: I haz the power, 2016-05-16 19:46:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 19:46:50]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-05-16 20:33:48]

https://codereview.chromium.org/1977373002/diff/20001/recipe_modules/gclient/...
File recipe_modules/gclient/example.py (right):

https://codereview.chromium.org/1977373002/diff/20001/recipe_modules/gclient/...
recipe_modules/gclient/example.py:97:
gclient_config=api.gclient.make_config('chromium_bare'))
sadly this call doesn't add anything to expectations, but since we have them in
build, i guess it's OK.

https://codereview.chromium.org/1977373002/diff/20001/recipe_modules/gclient/...
recipe_modules/gclient/example.py:110: api.properties(patch_project='webrtc')
nit: these kwargs can be inside .tryserver() above.

[tandrii(chromium), 2016-05-16 20:33:55]

lgtm

[kjellander_chromium, 2016-05-16 20:41:44]

https://codereview.chromium.org/1977373002/diff/20001/recipe_modules/gclient/...
File recipe_modules/gclient/example.py (right):

https://codereview.chromium.org/1977373002/diff/20001/recipe_modules/gclient/...
recipe_modules/gclient/example.py:97:
gclient_config=api.gclient.make_config('chromium_bare'))
On 2016/05/16 20:33:48, tandrii(chromium)-traveling wrote:
> sadly this call doesn't add anything to expectations, but since we have them
in
> build, i guess it's OK.

Right, it's just here for coverage.

https://codereview.chromium.org/1977373002/diff/20001/recipe_modules/gclient/...
recipe_modules/gclient/example.py:110: api.properties(patch_project='webrtc')
On 2016/05/16 20:33:48, tandrii(chromium)-traveling wrote:
> nit: these kwargs can be inside .tryserver() above.

Done.

[kjellander_chromium, 2016-05-16 20:41:55]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-05-16 20:41:56]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1977373002/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-05-16 20:41:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977373002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977373002/40001

[commit-bot: I haz the power, 2016-05-16 20:44:54]

Description was changed from

==========
Fix revision for WebRTC patches sent to Chromium trybots

This will have the revision set properly to 'HEAD' before attempting
to apply the patch.
It should also solve the problem that analyze is ending up with
no changes when running 'git diff'.

Expectation update in: https://codereview.chromium.org/1984673002

BUG=438952
==========

to

==========
Fix revision for WebRTC patches sent to Chromium trybots

This will have the revision set properly to 'HEAD' before attempting
to apply the patch.
It should also solve the problem that analyze is ending up with
no changes when running 'git diff'.

Expectation update in: https://codereview.chromium.org/1984673002

BUG=438952

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300603
==========

[commit-bot: I haz the power, 2016-05-16 20:44:55]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300603