Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1977343002: With LSan, run initial heap cleaning GCs during shutdown. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

With LSan, run initial heap cleaning GCs during shutdown. Clean out as much as garbage as possible before releasing a thread's static persistents, in preparation for LSan leak detection. By doing so, finalizers for itinerant garbage may access these static local persistents without restrictions, _but_ any object kept alive by a static persistent may not when the second phase of cleaning GCs are performed. As collectAllGarbage() stops on reaching a fixed point, extra overhead of having to perform GCs before and after the static persistents isn't a concern. R= BUG=611333 Committed: https://crrev.com/a2917a54ac168cd4ccb8bf453a44cadd38ec0c6b Cr-Commit-Position: refs/heads/master@{#393809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-16 06:06:22 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-16 06:49:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977343002/1
4 years, 7 months ago (2016-05-16 07:54:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 07:57:36 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 07:58:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2917a54ac168cd4ccb8bf453a44cadd38ec0c6b
Cr-Commit-Position: refs/heads/master@{#393809}

Powered by Google App Engine
This is Rietveld 408576698