testharnessreport: Clear BODY content regardless of existence of <div id=log>

testharnessreport: Clear BODY content regardless of existence of <div id=log>

* http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
 We need to convert this test to js-test.js from testharness.js.
 We can't support text dump comparison in testharness.js.

BUG=592827
NOPRESUBMIT=true

Committed: https://crrev.com/dece45a598ee515714d2929c9f0dad05d7451679
Cr-Commit-Position: refs/heads/master@{#394048}

[tkent, 2016-05-16 08:21:38]

Patchset #1 (id:1) has been deleted

[tkent, 2016-05-16 08:38:00]

Description was changed from

==========
testharnessreport: Clear BODY content regardless of existence of <div id=log>

BUG=592827
==========

to

==========
testharnessreport: Clear BODY content regardless of existence of <div id=log>

*
http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
 We need to convert this test to js-test.js instead of testharness.js.
 We can't support text dump comparison in testharness.js.

BUG=592827
==========

[tkent, 2016-05-16 08:39:17]

tkent@chromium.org changed reviewers:
+ falken@chromium.org, kojii@chromium.org

[tkent, 2016-05-16 08:39:18]

falken@, would you review global-interface-listing-service-worker.html please?
kojii@, would you review the whole change please?

[tkent, 2016-05-16 08:48:46]

Description was changed from

==========
testharnessreport: Clear BODY content regardless of existence of <div id=log>

*
http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
 We need to convert this test to js-test.js instead of testharness.js.
 We can't support text dump comparison in testharness.js.

BUG=592827
==========

to

==========
testharnessreport: Clear BODY content regardless of existence of <div id=log>

*
http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
 We need to convert this test to js-test.js from testharness.js.
 We can't support text dump comparison in testharness.js.

BUG=592827
==========

[falken, 2016-05-16 08:59:43]

https://codereview.chromium.org/1977313003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
(right):

https://codereview.chromium.org/1977313003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html:58:
}
I think this can be written more clearly as an unnested chain of promises.
Totally untested, but something like the below.

Note also this follows the serviceworker style guide for indents:
https://www.chromium.org/blink/serviceworker/testing

unregisterServiceWorker(scope)
  .then(() => navigator.serviceWorker.register(...))
  .then(registration => {
      var sw = registration.installing;
      return new Promise(resolve => {
          var message_channel = new MessageChannel
          message_channel.port1.onmessage = (evt => resolve(evt));
          sw.postMessage(null, [message_channel.port2]);
        });
    })
  .then(evt => {
      var pre = document.createElement('pre');
      pre.appendChild(document.createTextNode(evt.data.result.join('\n')));
      document.body.insertBefore(pre, document.body.firstChild);
      return unregisterServiceWorker(scope);
    })
  .then(() => {
      testPassed('Verify the interface of ServiceWorkerGlobalScope');
      finishJSTest();
    })
  .catch(error => {
      testFailed('error: ' + (error.message || error.name || error));
      finishJSTest();
    });

[tkent, 2016-05-16 14:41:17]

https://codereview.chromium.org/1977313003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
(right):

https://codereview.chromium.org/1977313003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html:58:
}
On 2016/05/16 at 08:59:43, falken wrote:
> I think this can be written more clearly as an unnested chain of promises.
Totally untested, but something like the below.
> 
> Note also this follows the serviceworker style guide for indents:
> https://www.chromium.org/blink/serviceworker/testing

Thank you for the advice!  Done.

[kojii, 2016-05-16 14:43:32]

lgtm

[tkent, 2016-05-17 01:42:43]

falken@, would you take another look at
global-interface-listing-service-worker.html please?

[falken, 2016-05-17 01:51:33]

lgtm

https://codereview.chromium.org/1977313003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
(right):

https://codereview.chromium.org/1977313003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html:15:
function unregister_service_worker(documentUrl) {
document_url for consistency

https://codereview.chromium.org/1977313003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html:23:
});
I would just have this return a promise:

return navigator.serviceWorker.getRegistration(documentUrl)
  .then(registration => {
      if (registration)
        return registration.unregister();
    });

Then the main promise chain would catch a rejection and call
testFailed/finishJSTest

[tkent, 2016-05-17 03:37:54]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-05-17 03:37:54]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
kojii@chromium.org
Link to the patchset: https://codereview.chromium.org/1977313003/#ps80001
(title: "Fix unregister_service_worker()")

[commit-bot: I haz the power, 2016-05-17 03:38:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977313003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977313003/80001

[tkent, 2016-05-17 03:38:24]

https://codereview.chromium.org/1977313003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
(right):

https://codereview.chromium.org/1977313003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html:15:
function unregister_service_worker(documentUrl) {
On 2016/05/17 at 01:51:33, falken wrote:
> document_url for consistency

Done

https://codereview.chromium.org/1977313003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html:23:
});
On 2016/05/17 at 01:51:33, falken wrote:
> I would just have this return a promise:
> 
> return navigator.serviceWorker.getRegistration(documentUrl)
>   .then(registration => {
>       if (registration)
>         return registration.unregister();
>     });
> 
> Then the main promise chain would catch a rejection and call
testFailed/finishJSTest

Done.

[commit-bot: I haz the power, 2016-05-17 03:45:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 03:45:23]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tkent, 2016-05-17 03:48:16]

Description was changed from

==========
testharnessreport: Clear BODY content regardless of existence of <div id=log>

*
http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
 We need to convert this test to js-test.js from testharness.js.
 We can't support text dump comparison in testharness.js.

BUG=592827
==========

to

==========
testharnessreport: Clear BODY content regardless of existence of <div id=log>

*
http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
 We need to convert this test to js-test.js from testharness.js.
 We can't support text dump comparison in testharness.js.

BUG=592827
NOPRESUBMIT=true
==========

[tkent, 2016-05-17 03:48:19]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-05-17 03:48:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977313003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977313003/80001

[commit-bot: I haz the power, 2016-05-17 04:36:43]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-05-17 04:37:47]

Description was changed from

==========
testharnessreport: Clear BODY content regardless of existence of <div id=log>

*
http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
 We need to convert this test to js-test.js from testharness.js.
 We can't support text dump comparison in testharness.js.

BUG=592827
NOPRESUBMIT=true
==========

to

==========
testharnessreport: Clear BODY content regardless of existence of <div id=log>

*
http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html
 We need to convert this test to js-test.js from testharness.js.
 We can't support text dump comparison in testharness.js.

BUG=592827
NOPRESUBMIT=true

Committed: https://crrev.com/dece45a598ee515714d2929c9f0dad05d7451679
Cr-Commit-Position: refs/heads/master@{#394048}
==========

[commit-bot: I haz the power, 2016-05-17 04:37:49]

Patchset 4 (id:??) landed as
https://crrev.com/dece45a598ee515714d2929c9f0dad05d7451679
Cr-Commit-Position: refs/heads/master@{#394048}