chrome/common/extensions/chrome_manifest_url_handlers.h - Issue 1977303004: [Extensions] Validate file existence for chrome url overrides

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_manifest_url_handlers.h

Issue 1977303004: [Extensions] Validate file existence for chrome url overrides (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/chrome_manifest_url_handlers.h

diff --git a/chrome/common/extensions/chrome_manifest_url_handlers.h b/chrome/common/extensions/chrome_manifest_url_handlers.h

index 6895ab997c6e228da82559579a83c271b114879f..a698c4504194ad8947c33b90f1e879c817d12f7a 100644

--- a/chrome/common/extensions/chrome_manifest_url_handlers.h

+++ b/chrome/common/extensions/chrome_manifest_url_handlers.h

@@ -59,6 +59,9 @@ class URLOverridesHandler : public ManifestHandler {

~URLOverridesHandler() override;

bool Parse(Extension* extension, base::string16* error) override;

+ bool Validate(const Extension* extension,

+ std::string* error,

+ std::vector<InstallWarning>* warnings) const override;

private:

const std::vector<std::string> Keys() const override;

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/extensions/chrome_manifest_url_handlers.cc » ('j') | no next file with comments »