third_party/WebKit/Source/core/frame/FrameSerializer.cpp - Issue 1977303003: Adds a feature to MHTML serialization that omits subframes and subresources marked no-store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameSerializer.cpp

Issue 1977303003: Adds a feature to MHTML serialization that omits subframes and subresources marked no-store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-store

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/mhtml_generation_browsertest.cc ('K') | « third_party/WebKit/Source/core/frame/FrameSerializer.h ('k') | third_party/WebKit/Source/web/WebFrameSerializer.cpp » ('j') | third_party/WebKit/Source/web/WebFrameSerializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameSerializer.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameSerializer.cpp b/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

index 6427f7e04fab9595002ef102e06221ba685c23a4..04e105240dedb6c14f08eba077c91c9cbbd5f482 100644

--- a/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

@@ -386,11 +386,14 @@ void FrameSerializer::serializeCSSRule(CSSRule* rule)

bool FrameSerializer::shouldAddURL(const KURL& url)

{

return url.isValid() && !m_resourceURLs.contains(url) && !url.protocolIsData()

- && !m_delegate.shouldSkipResource(url);

+ && !m_delegate.shouldSkipResourceWithURL(url);

}

void FrameSerializer::addToResources(Resource* resource, PassRefPtr<SharedBuffer> data, const KURL& url)

{

+ if (m_delegate.shouldSkipResource(resource))

+ return;

if (!data) {

DLOG(ERROR) << "No data for resource " << url.getString();

return;