content/public/common/mhtml_generation_params.h - Issue 1977303003: Adds a feature to MHTML serialization that omits subframes and subresources marked no-store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/mhtml_generation_params.h

Issue 1977303003: Adds a feature to MHTML serialization that omits subframes and subresources marked no-store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-store

Patch Set: Moar comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/mhtml_generation_browsertest.cc ('K') | « content/child/assert_matching_enums.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/mhtml_generation_params.h

diff --git a/content/public/common/mhtml_generation_params.h b/content/public/common/mhtml_generation_params.h

index c61879f0f183849399f9193300187d99392c8693..c0a36a47d2949334c567e7b02fcb9398f08c9d3e 100644

--- a/content/public/common/mhtml_generation_params.h

+++ b/content/public/common/mhtml_generation_params.h

@@ -15,11 +15,11 @@ namespace content {

enum class MHTMLCacheControlPolicy {

NONE = 0,

FAIL_FOR_NO_STORE_MAIN_FRAME,

+ SKIP_ANY_FRAME_OR_RESOURCE_MARKED_NO_STORE,

// |LAST| is used in content/public/common/common_param_traits_macros.h with

// IPC_ENUM_TRAITS_MAX_VALUE macro. Keep the value up to date. Otherwise

// a new value can not be passed to the renderer.

- LAST = FAIL_FOR_NO_STORE_MAIN_FRAME

+ LAST = SKIP_ANY_FRAME_OR_RESOURCE_MARKED_NO_STORE

dcheng 2016/05/20 20:25:02 Seems like it'd be easier to just use the Web enum

dewittj 2016/05/20 21:22:22 Done.

};

struct CONTENT_EXPORT MHTMLGenerationParams {