chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc - Issue 1977303003: Adds a feature to MHTML serialization that omits subframes and subresources marked no-store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

Issue 1977303003: Adds a feature to MHTML serialization that omits subframes and subresources marked no-store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-store

Patch Set: Moar comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

index ed0c1bfd3e99f5ed1819e3c2215258214f3b7bd1..357701aa7e624652ee78e347f4b85cc2e55ee543 100644

--- a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

+++ b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

@@ -121,8 +121,8 @@ void OfflinePageMHTMLArchiver::GenerateMHTML(

GenerateFileName(url, base::UTF16ToUTF8(title), archive_id)));

content::MHTMLGenerationParams params(file_path);

- params.cache_control_policy =

- content::MHTMLCacheControlPolicy::FAIL_FOR_NO_STORE_MAIN_FRAME;

+ params.cache_control_policy = content::MHTMLCacheControlPolicy::

+ SKIP_ANY_FRAME_OR_RESOURCE_MARKED_NO_STORE;

params.use_binary_encoding = true;

web_contents_->GenerateMHTML(

« no previous file with comments | « no previous file | content/browser/download/mhtml_generation_browsertest.cc » ('j') | content/browser/download/mhtml_generation_browsertest.cc » ('J')