Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: third_party/WebKit/Source/core/frame/FrameSerializer.h

Issue 1977303003: Adds a feature to MHTML serialization that omits subframes and subresources marked no-store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-store
Patch Set: Adds a test that compares actual visible content. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameSerializer.h
diff --git a/third_party/WebKit/Source/core/frame/FrameSerializer.h b/third_party/WebKit/Source/core/frame/FrameSerializer.h
index 9aaf155303aa327a2b38ecb37bc3f76ff5d6ceef..d6c1c8ba8b4f60deb1843c3cc1df87ac2d355612 100644
--- a/third_party/WebKit/Source/core/frame/FrameSerializer.h
+++ b/third_party/WebKit/Source/core/frame/FrameSerializer.h
@@ -85,9 +85,15 @@ public:
return false;
}
- // Tells whether to skip serialization of a subresource with a given URI.
- // Used to deduplicate resources across multiple frames.
- virtual bool shouldSkipResource(const KURL&)
+ // Tells whether to skip serialization of a subresource or CSSStyleSheet
+ // with a given URI. Used to deduplicate resources across multiple frames.
+ virtual bool shouldSkipResourceWithURL(const KURL&)
Łukasz Anforowicz 2016/05/19 17:00:13 Nice name change. Long time ago this was also use
dewittj 2016/05/19 18:18:36 Acknowledged.
+ {
+ return false;
+ }
+
+ // Tells whether to skip serialization of a subresource.
+ virtual bool shouldSkipResource(Resource*)
{
return false;
}

Powered by Google App Engine
This is Rietveld 408576698