chrome/test/chromedriver/commands.cc - Issue 19773012: [chromedriver] Accept loadAsync as a non-op chromeOption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/commands.cc

Issue 19773012: [chromedriver] Accept loadAsync as a non-op chromeOption. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unittest. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/commands.cc

diff --git a/chrome/test/chromedriver/commands.cc b/chrome/test/chromedriver/commands.cc

index 6ab61351985aa967ee28e7afa1208f479b74fdb8..ac0eeea95f0561c5efe5830e0622612811289fc8 100644

--- a/chrome/test/chromedriver/commands.cc

+++ b/chrome/test/chromedriver/commands.cc

@@ -88,7 +88,7 @@ Status CreateSessionOnSessionThreadHelper(

return Status(kUnknownError, "cannot find dict 'desiredCapabilities'");

Capabilities capabilities;

- Status status = capabilities.Parse(*desired_caps);

+ Status status = capabilities.Parse(*desired_caps, bound_params.log);

if (status.IsError())

return status;

« no previous file with comments | « chrome/test/chromedriver/capabilities_unittest.cc ('k') | no next file » | no next file with comments »