Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1977293002: Remove Windows Vista/XP specific code from net/quic. (Closed)

Created:
4 years, 7 months ago by martijnc
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Windows Vista/XP specific code from net/quic. BUG=580691 Committed: https://crrev.com/e3a795ebed090c2b43e8dcf2af854382b5d3a7b0 Cr-Commit-Position: refs/heads/master@{#394869}

Patch Set 1 : #

Patch Set 2 : removed QuicCryptoClientConfig changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M net/quic/crypto/proof_test.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
martijnc
Hi, can you review this patch? Thanks!
4 years, 7 months ago (2016-05-16 20:28:31 UTC) #5
Ryan Hamilton
This change looks good, but there's a bit more to be removed. Since this code ...
4 years, 7 months ago (2016-05-17 21:18:39 UTC) #6
martijnc
On 2016/05/17 at 21:18:39, rch wrote: > This change looks good, but there's a bit ...
4 years, 7 months ago (2016-05-18 17:04:53 UTC) #7
Ryan Hamilton
lgtm
4 years, 7 months ago (2016-05-18 21:35:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977293002/60001
4 years, 7 months ago (2016-05-19 16:57:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/216698)
4 years, 7 months ago (2016-05-19 18:54:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977293002/60001
4 years, 7 months ago (2016-05-19 19:03:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-05-19 21:22:05 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 21:23:19 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3a795ebed090c2b43e8dcf2af854382b5d3a7b0
Cr-Commit-Position: refs/heads/master@{#394869}

Powered by Google App Engine
This is Rietveld 408576698