Issue 1977213002: Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1449)

My Issues | Starred Open | Closed | All

Issue 1977213002: Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd (Closed)

Created:
4 years, 7 months ago by dominicc (has gone to gerrit)

Modified:
4 years, 7 months ago

Reviewers:
Dirk Pranke, scottmg

CC:
chromium-reviews, tomz

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd This rolls in changes from git://git.gnome.org/libxml2 in this commit range: 6657afe83a38278f124ace71dc85f60420beb2d5..8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd These commits mention the following upstream bugs: https://bugzilla.gnome.org/show_bug.cgi?id=709171 https://bugzilla.gnome.org/show_bug.cgi?id=721158 https://bugzilla.gnome.org/show_bug.cgi?id=750037 https://bugzilla.gnome.org/show_bug.cgi?id=756075 https://bugzilla.gnome.org/show_bug.cgi?id=758514 https://bugzilla.gnome.org/show_bug.cgi?id=758572 https://bugzilla.gnome.org/show_bug.cgi?id=759671 https://bugzilla.gnome.org/show_bug.cgi?id=760183 https://bugzilla.gnome.org/show_bug.cgi?id=760190 https://bugzilla.gnome.org/show_bug.cgi?id=760249 https://bugzilla.gnome.org/show_bug.cgi?id=760325 https://bugzilla.gnome.org/show_bug.cgi?id=760861 https://bugzilla.gnome.org/show_bug.cgi?id=760921 https://bugzilla.gnome.org/show_bug.cgi?id=761782 https://bugzilla.gnome.org/show_bug.cgi?id=761784 https://bugzilla.gnome.org/show_bug.cgi?id=765979 BUG=611953 Committed: https://crrev.com/9bed3b64d67b1b315cf93d84a6af60145841e602 Cr-Commit-Position: refs/heads/master@{#394029}

Patch Set 1 #

Patch Set 2 : Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd #

Patch Set 3 : Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd #

Patch Set 4 : Update README.chromium. #

Total comments: 1

Created: 4 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7278 lines, -14809 lines)			Patch
	M	third_party/libxml/README.chromium	View	1 2 3	3 chunks	+46 lines, -38 lines	0 comments	Download
	M	third_party/libxml/linux/config.h	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
	M	third_party/libxml/linux/include/libxml/xmlversion.h	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download
	M	third_party/libxml/linux/xml2-config	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download
	M	third_party/libxml/mac/config.h	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/mac/include/libxml/xmlversion.h	View	2 3	2 chunks	+4 lines, -4 lines	0 comments	Download
	M	third_party/libxml/src/COPYING	View	2 3	1 chunk	+674 lines, -23 lines	1 comment	Download
	M	third_party/libxml/src/ChangeLog	View	2 3	8 chunks	+12 lines, -12 lines	0 comments	Download
	M	third_party/libxml/src/HTMLparser.c	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/src/Makefile.am	View	2 3	2 chunks	+5 lines, -1 line	0 comments	Download
	M	third_party/libxml/src/Makefile.in	View	1 2 3	16 chunks	+32 lines, -37 lines	0 comments	Download
	M	third_party/libxml/src/NEWS	View	2 3	9 chunks	+11 lines, -11 lines	0 comments	Download
	M	third_party/libxml/src/aclocal.m4	View	1 2 3	23 chunks	+67 lines, -89 lines	0 comments	Download
	M	third_party/libxml/src/bakefile/Bakefiles.bkgen	View	2 3	1 chunk	+14 lines, -14 lines	0 comments	Download
	M	third_party/libxml/src/bakefile/Readme.txt	View	2 3	1 chunk	+92 lines, -92 lines	0 comments	Download
	M	third_party/libxml/src/bakefile/libxml2.bkl	View	2 3	1 chunk	+749 lines, -749 lines	0 comments	Download
	M	third_party/libxml/src/catalog.c	View	2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
	M	third_party/libxml/src/compile	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/src/config.guess	View	2 3	9 chunks	+169 lines, -32 lines	0 comments	Download
	M	third_party/libxml/src/config.sub	View	2 3	17 chunks	+14 lines, -30 lines	0 comments	Download
	M	third_party/libxml/src/config.h.in	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
	M	third_party/libxml/src/configure	View	1 2 3	244 chunks	+1180 lines, -1286 lines	0 comments	Download
	M	third_party/libxml/src/configure.ac	View	2 3	5 chunks	+92 lines, -29 lines	0 comments	Download
	M	third_party/libxml/src/debugXML.c	View	2 3	4 chunks	+5 lines, -5 lines	0 comments	Download
	M	third_party/libxml/src/depcomp	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/src/dict.c	View	2 3	16 chunks	+25 lines, -25 lines	0 comments	Download
	M	third_party/libxml/src/error.c	View	2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	third_party/libxml/src/include/Makefile.in	View	1 2 3	11 chunks	+10 lines, -21 lines	0 comments	Download
	M	third_party/libxml/src/include/libxml/Makefile.in	View	1 2 3	11 chunks	+11 lines, -22 lines	0 comments	Download
	M	third_party/libxml/src/include/libxml/dict.h	View	2 3	4 chunks	+14 lines, -8 lines	0 comments	Download
	M	third_party/libxml/src/include/libxml/parser.h	View	2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	third_party/libxml/src/include/libxml/schemasInternals.h	View	2 3	1 chunk	+46 lines, -46 lines	0 comments	Download
	M	third_party/libxml/src/include/libxml/xpathInternals.h	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/src/install-sh	View	2 3	12 chunks	+196 lines, -170 lines	0 comments	Download
	M	third_party/libxml/src/libxml.spec.in	View	2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
	D	third_party/libxml/src/libxml2.spec	View	2 3	1 chunk	+0 lines, -199 lines	0 comments	Download
	M	third_party/libxml/src/ltmain.sh	View	1 2 3	360 chunks	+2018 lines, -3504 lines	0 comments	Download
	M	third_party/libxml/src/m4/libtool.m4	View	1 2 3	267 chunks	+1088 lines, -1463 lines	0 comments	Download
	M	third_party/libxml/src/m4/ltoptions.m4	View	1 2 3	15 chunks	+37 lines, -90 lines	0 comments	Download
	M	third_party/libxml/src/m4/ltsugar.m4	View	2 3	3 chunks	+3 lines, -4 lines	0 comments	Download
	M	third_party/libxml/src/m4/ltversion.m4	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
	M	third_party/libxml/src/m4/lt~obsolete.m4	View	2 3	3 chunks	+3 lines, -4 lines	0 comments	Download
	M	third_party/libxml/src/macos/src/XMLTestPrefix.h	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/src/macos/src/XMLTestPrefix2.h	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/src/macos/src/libxml2_GUSIConfig.cp	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/src/macos/src/macos_main.c	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/src/missing	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/src/parser.c	View	2 3	10 chunks	+11 lines, -10 lines	0 comments	Download
	M	third_party/libxml/src/schematron.c	View	2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	third_party/libxml/src/testapi.c	View	2 3	7 chunks	+7 lines, -7 lines	0 comments	Download
	M	third_party/libxml/src/tree.c	View	2 3	7 chunks	+7 lines, -7 lines	0 comments	Download
	M	third_party/libxml/src/valid.c	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libxml/src/win32/VC10/README.vc10	View	2 3	1 chunk	+27 lines, -27 lines	0 comments	Download
	M	third_party/libxml/src/win32/VC10/RuleSet1.ruleset	View	2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
	D	third_party/libxml/src/win32/VC10/config.h	View	1 2 3	1 chunk	+0 lines, -125 lines	0 comments	Download
	D	third_party/libxml/src/xmlcatalog.c	View	2 3	1 chunk	+0 lines, -615 lines	0 comments	Download
	D	third_party/libxml/src/xmllint.c	View	2 3	1 chunk	+0 lines, -3801 lines	0 comments	Download
	M	third_party/libxml/src/xmlreader.c	View	2 3	4 chunks	+4 lines, -4 lines	0 comments	Download
	M	third_party/libxml/src/xmlregexp.c	View	2 3	5 chunks	+11 lines, -6 lines	0 comments	Download
	M	third_party/libxml/src/xmlschemas.c	View	2 3	2 chunks	+11 lines, -4 lines	0 comments	Download
	M	third_party/libxml/src/xmlschemastypes.c	View	2 3	6 chunks	+19 lines, -6 lines	0 comments	Download
	M	third_party/libxml/src/xpath.c	View	2 3	12 chunks	+30 lines, -36 lines	0 comments	Download
	D	third_party/libxml/src/xstc/Makefile.am	View	2 3	1 chunk	+0 lines, -132 lines	0 comments	Download
	D	third_party/libxml/src/xstc/Makefile.in	View	2 3	1 chunk	+0 lines, -681 lines	0 comments	Download
	D	third_party/libxml/src/xstc/xstc.py	View	2 3	1 chunk	+0 lines, -693 lines	0 comments	Download
	D	third_party/libxml/src/xstc/xstc-to-python.xsl	View	2 3	1 chunk	+0 lines, -114 lines	0 comments	Download
	M	third_party/libxml/win32/config.h	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
	A +	third_party/libxml/win32/xmlversion.h	View	2 3	1 chunk	+489 lines, -489 lines	0 comments	Download

Messages

Total messages: 14 (6 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dominicc (has gone to gerrit)

Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd

4 years, 7 months ago (2016-05-14 03:51:41 UTC) #1

dominicc (has gone to gerrit)

Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd

4 years, 7 months ago (2016-05-14 04:23:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977213002/40001

4 years, 7 months ago (2016-05-17 01:07:16 UTC) #8

commit-bot: I haz the power

Patchset 4 (id:??) landed as https://crrev.com/9bed3b64d67b1b315cf93d84a6af60145841e602 Cr-Commit-Position: refs/heads/master@{#394029}

4 years, 7 months ago (2016-05-17 02:45:38 UTC) #11

Dirk Pranke

4 years, 7 months ago (2016-05-17 19:01:06 UTC) #13

Message was sent while issue was closed.

https://codereview.chromium.org/1977213002/diff/40001/third_party/libxml/src/...
File third_party/libxml/src/COPYING (right):

https://codereview.chromium.org/1977213002/diff/40001/third_party/libxml/src/...
third_party/libxml/src/COPYING:2: Version 3, 29 June 2007
Where does this file come from? I don't even see a COPYING file in the upstream
repo, but the Copyright file is still the old license from Daniel Veillard.

We can't link against something containing GPLv3, so I'm reverting this for now.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698