Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1977183002:
Removed ctrl-shift-p from the keyboard shortcut overlay. (Closed)
|
Created:
4 years, 7 months ago by sammiequon Modified:
4 years, 6 months ago CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemoved ctrl-shift-p from the keyboard
shortcut overlay.
BUG=608315
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/c3d972259673511bbdbb6c3c21ebc18c0e8eda6e
Cr-Commit-Position: refs/heads/master@{#398157}
Patch Set 1 #Patch Set 2 : Removed some additional strings regarding Google cloud print. #
Messages
Total messages: 26 (12 generated)
Description was changed from ========== Removed CTRL-SHIFT-P from showing anything on the keyboard shortcut GUI. BUG= ========== to ========== Removed CTRL-SHIFT-P from showing anything on the keyboard shortcut GUI. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Removed CTRL-SHIFT-P from showing anything on the keyboard shortcut GUI. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Removed CTRL-SHIFT-P from showing anything on the keyboard shortcut GUI. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
sammiequon@chromium.org changed reviewers: + jdufault@chromium.org
Please add a reference to bug 608315 on the BUG= line. ctrl-shift-p doesn't do anything, right? There is no additional code to remove?
Description was changed from ========== Removed CTRL-SHIFT-P from showing anything on the keyboard shortcut GUI. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Removed CTRL-SHIFT-P from showing anything on the keyboard shortcut GUI. BUG=608315 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
On 2016/05/17 18:36:29, jdufault wrote: > Please add a reference to bug 608315 on the BUG= line. > > ctrl-shift-p doesn't do anything, right? There is no additional code to remove? Yes ctrl-shift-p is depreciated now and the patch solves this.
What about changing the description to "Removed ctrl-shift-p from the keyboard shortcut overlay." You also need to remove the code at [1] and [2]. 1: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chromeo... 2: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
Description was changed from ========== Removed CTRL-SHIFT-P from showing anything on the keyboard shortcut GUI. BUG=608315 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Removed ctrl-shift-p from the keyboard shortcut overlay. BUG=608315 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
On 2016/05/17 23:22:09, jdufault wrote: > What about changing the description to "Removed ctrl-shift-p from the keyboard > shortcut overlay." > > You also need to remove the code at [1] and [2]. > > 1: > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chromeo... > 2: > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/... Added requested updates.
On 2016/05/17 23:22:09, jdufault wrote: > What about changing the description to "Removed ctrl-shift-p from the keyboard > shortcut overlay." > > You also need to remove the code at [1] and [2]. > > 1: > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chromeo... > 2: > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/... Added requested updates.
On 2016/05/20 19:13:21, sammiequon wrote: > On 2016/05/17 23:22:09, jdufault wrote: > > What about changing the description to "Removed ctrl-shift-p from the keyboard > > shortcut overlay." > > > > You also need to remove the code at [1] and [2]. > > > > 1: > > > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chromeo... > > 2: > > > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/... > > Added requested updates. Looks like you need to run `git cl upload` - your changes have not been uploaded to the code review.
lgtm
The CQ bit was checked by sammiequon@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977183002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was unchecked by sammiequon@chromium.org
sammiequon@chromium.org changed reviewers: + xiyuan@chromium.org
@xiyuan -please take a look.
lgtm
The CQ bit was checked by sammiequon@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977183002/20001
Message was sent while issue was closed.
Description was changed from ========== Removed ctrl-shift-p from the keyboard shortcut overlay. BUG=608315 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Removed ctrl-shift-p from the keyboard shortcut overlay. BUG=608315 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Removed ctrl-shift-p from the keyboard shortcut overlay. BUG=608315 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Removed ctrl-shift-p from the keyboard shortcut overlay. BUG=608315 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c3d972259673511bbdbb6c3c21ebc18c0e8eda6e Cr-Commit-Position: refs/heads/master@{#398157} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c3d972259673511bbdbb6c3c21ebc18c0e8eda6e Cr-Commit-Position: refs/heads/master@{#398157} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
