core/fxcrt/include/fx_string.h - Issue 1977093002: Make CFX_ByteString(const CFX_ByteStringC&) explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/include/fx_string.h

Issue 1977093002: Make CFX_ByteString(const CFX_ByteStringC&) explicit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: First mac-only fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/include/fx_string.h

diff --git a/core/fxcrt/include/fx_string.h b/core/fxcrt/include/fx_string.h

index 617e02ee5a460dabea3e94ee3849ad2079e5ceba..b55fe509a54532b1ac65abeb9c3d57e1cb6cbdfd 100644

--- a/core/fxcrt/include/fx_string.h

+++ b/core/fxcrt/include/fx_string.h

@@ -159,8 +159,7 @@ class CFX_ByteString {

CFX_ByteString(const FX_CHAR* ptr, FX_STRSIZE len);

CFX_ByteString(const uint8_t* ptr, FX_STRSIZE len);

- // TODO(tsepez): mark constructor as explicit.

- CFX_ByteString(const CFX_ByteStringC& bstrc);

+ explicit CFX_ByteString(const CFX_ByteStringC& bstrc);

CFX_ByteString(const CFX_ByteStringC& bstrc1, const CFX_ByteStringC& bstrc2);

~CFX_ByteString();