fpdfsdk/formfiller/cba_fontmap.cpp - Issue 1977093002: Make CFX_ByteString(const CFX_ByteStringC&) explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/formfiller/cba_fontmap.cpp

Issue 1977093002: Make CFX_ByteString(const CFX_ByteStringC&) explicit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, nit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/formfiller/cba_fontmap.cpp

diff --git a/fpdfsdk/formfiller/cba_fontmap.cpp b/fpdfsdk/formfiller/cba_fontmap.cpp

index 00e213c7d7f3427025a94b4f2c16a5e8863f58db..4c74d5a242a4b9c4ae6abfd0a0f56bab5b631e66 100644

--- a/fpdfsdk/formfiller/cba_fontmap.cpp

+++ b/fpdfsdk/formfiller/cba_fontmap.cpp

@@ -167,7 +167,7 @@ void CBA_FontMap::AddFontToAnnotDict(CPDF_Font* pFont,

if (!pStream) {

pStream = new CPDF_Stream(NULL, 0, NULL);

int32_t objnum = m_pDocument->AddIndirectObject(pStream);

- pAPDict->SetAtReference(m_sAPType.AsStringC(), m_pDocument, objnum);

+ pAPDict->SetAtReference(m_sAPType, m_pDocument, objnum);

}

CPDF_Dictionary* pStreamDict = pStream->GetDict();

@@ -223,7 +223,7 @@ CPDF_Font* CBA_FontMap::GetAnnotDefaultFont(CFX_ByteString& sAlias) {

if (!sDA.IsEmpty()) {

CPDF_SimpleParser syntax(sDA.AsStringC());

syntax.FindTagParamFromStart("Tf", 2);

- CFX_ByteString sFontName = syntax.GetWord();

+ CFX_ByteString sFontName(syntax.GetWord());

sAlias = PDF_NameDecode(sFontName).Mid(1);

if (CPDF_Dictionary* pDRDict = m_pAnnotDict->GetDictBy("DR"))

« no previous file with comments | « core/fxge/include/fx_font.h ('k') | fpdfsdk/fpdf_transformpage.cpp » ('j') | no next file with comments »