core/fxcrt/fx_basic_bstring.cpp - Issue 1977093002: Make CFX_ByteString(const CFX_ByteStringC&) explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_basic_bstring.cpp

Issue 1977093002: Make CFX_ByteString(const CFX_ByteStringC&) explicit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, nit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_basic_bstring.cpp

diff --git a/core/fxcrt/fx_basic_bstring.cpp b/core/fxcrt/fx_basic_bstring.cpp

index c774e80cb7adda5cc1a5af2d942e6376987ecb68..379f1ee882ca2673de6da276548194dbcb7b3a0e 100644

--- a/core/fxcrt/fx_basic_bstring.cpp

+++ b/core/fxcrt/fx_basic_bstring.cpp

@@ -408,7 +408,7 @@ void CFX_ByteString::AllocCopy(CFX_ByteString& dest,

CFX_ByteString CFX_ByteString::FormatInteger(int i, uint32_t flags) {

char buf[32];

- return CFX_ByteStringC(buf, Buffer_itoa(buf, i, flags));

+ return CFX_ByteString(buf, Buffer_itoa(buf, i, flags));

}

void CFX_ByteString::FormatV(const FX_CHAR* pFormat, va_list argList) {

« no previous file with comments | « core/fxcodec/codec/fx_codec_icc.cpp ('k') | core/fxcrt/fx_basic_buffer.cpp » ('j') | no next file with comments »