Move line/continuation specific parts of willBeDestroyed() into LayoutBlockFlow.

third_party/WebKit/Source/core/layout/LayoutBlock.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 106 matching lines @@
     LayoutObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }
     LayoutObject* lastChild() const { ASSERT(children() == virtualChildren()); return children()->lastChild(); }
 
     // If you have a LayoutBlock, use firstChild or lastChild instead.
     void slowFirstChild() const = delete;
     void slowLastChild() const = delete;
 
     const LayoutObjectChildList* children() const { return &m_children; }
     LayoutObjectChildList* children() { return &m_children; }
 
-    bool beingDestroyed() const { return m_beingDestroyed; }

[szager1, 2016/05/16 16:56:40]

Sorry to jump in here, but I don't like moving this method to LayoutBlockFlow
while the bitfield is still defined on LayoutBlock.  Can we leave it here?

[mstensho (USE GERRIT), 2016/05/16 17:57:27]

I moved it because the flag is now only set by LayoutBlockFlow, so it would
always be false for other types of LayoutBlock - which kind of seemed misleading
and unuseful to me.

Also note that there's nothing unusual about having bitfields in LayoutBlock
that are only used in subclasses, though. Establishing a bit field typically
requires the size of an int, so keeping them all in LayoutBlock makes sense,
when there are so few of them.

See m_hasMarkupTruncation, m_isSelfCollapsing,
m_descendantsWithFloatsMarkedForLayout...

-
     // These two functions are overridden for inline-block.
     LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const final;
     int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const override;
 
     LayoutUnit minLineHeightForReplacedObject(bool isFirstLine, LayoutUnit replacedHeight) const;
 
     bool createsNewFormattingContext() const;
 
     const LineBoxList& lineBoxes() const { return m_lineBoxes; }
     LineBoxList* lineBoxes() { return &m_lineBoxes; }
@@ skipping 330 matching lines @@
     // FIXME: This is temporary as we move code that accesses block flow
     // member variables out of LayoutBlock and into LayoutBlockFlow.
     friend class LayoutBlockFlow;
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
 
 } // namespace blink
 
 #endif // LayoutBlock_h