Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1977003002: Update dart:collection. (Closed)

Created:
4 years, 7 months ago by Bob Nystrom
Modified:
4 years, 7 months ago
Reviewers:
sra1
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update dart:collection. This doesn't include the copious changes in collection_patch.dart because I believe (1) those are quite old and (2) are dart2js specific. The changes here have basically no effect on DDC, but it at least gets us a little better test coverage and reduces noise in the diffs. R=sra@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/26f882c4672b6358611ae011e4a7cfc11d02cd6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -26 lines) Patch
M lib/runtime/dart_sdk.js View 4 chunks +10 lines, -5 lines 0 comments Download
M test/codegen/corelib/set_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A test/codegen/lib/collection/hash_map_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A test/codegen/lib/collection/hash_set_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download
A test/codegen/lib/collection/linked_list_test.dart View 1 chunk +175 lines, -0 lines 0 comments Download
M tool/input_sdk/lib/collection/hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/collection/hash_set.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tool/input_sdk/lib/collection/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/collection/linked_hash_set.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tool/input_sdk/lib/collection/linked_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/collection/queue.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M tool/input_sdk/lib/collection/splay_tree.dart View 12 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Bob Nystrom
4 years, 7 months ago (2016-05-13 16:44:28 UTC) #2
Bob Nystrom
4 years, 7 months ago (2016-05-16 19:30:02 UTC) #5
sra1
lgtm
4 years, 7 months ago (2016-05-16 19:32:51 UTC) #6
Bob Nystrom
4 years, 7 months ago (2016-05-17 22:39:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26f882c4672b6358611ae011e4a7cfc11d02cd6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698