content/browser/renderer_host/pepper/pepper_file_ref_host.h - Issue 19770009: PepperFileRefHost: Port to use explicit permission grants in ChildProcessSecurityPolicy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_file_ref_host.h

Issue 19770009: PepperFileRefHost: Port to use explicit permission grants in ChildProcessSecurityPolicy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0044-write-support-remove-child-process-security-policy-bitmask-usage

Patch Set: address kinuko comment. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc ('K') | « content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc ('k') | content/browser/renderer_host/pepper/pepper_file_ref_host.cc » ('j') | content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_file_ref_host.h

diff --git a/content/browser/renderer_host/pepper/pepper_file_ref_host.h b/content/browser/renderer_host/pepper/pepper_file_ref_host.h

index 480bc31fa54b4a0460fd7ef1c625c7be37da430c..ce742faebfbffcb43ccdd83faae93c259d02cb6f 100644

--- a/content/browser/renderer_host/pepper/pepper_file_ref_host.h

+++ b/content/browser/renderer_host/pepper/pepper_file_ref_host.h

@@ -46,7 +46,10 @@ class PepperFileRefBackend {

virtual base::FilePath GetExternalPath() const = 0;

// Returns an error from the pp_errors.h enum.

- virtual int32_t HasPermissions(int permissions) const = 0;

+ virtual int32_t CanRead() const = 0;

+ virtual int32_t CanWrite() const = 0;

+ virtual int32_t CanCreate() const = 0;

+ virtual int32_t CanReadWrite() const = 0;

};

class CONTENT_EXPORT PepperFileRefHost

@@ -80,7 +83,10 @@ class CONTENT_EXPORT PepperFileRefHost

std::string GetFileSystemURLSpec() const;

base::FilePath GetExternalPath() const;

- int32_t HasPermissions(int permissions) const;

+ int32_t CanRead() const;

+ int32_t CanWrite() const;

+ int32_t CanCreate() const;

+ int32_t CanReadWrite() const;

private:

int32_t OnMakeDirectory(ppapi::host::HostMessageContext* context,