PepperFileRefHost: Port to use explicit permission grants in ChildProcessSecurityPolicy.

content/browser/renderer_host/pepper/pepper_file_ref_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/pepper/pepper_file_ref_host.h"
 
 #include <string>
 
 #include "content/browser/renderer_host/pepper/pepper_external_file_ref_backend.h"
 #include "content/browser/renderer_host/pepper/pepper_file_system_browser_host.h"
@@ skipping 109 matching lines @@
     return backend_->GetFileSystemURLSpec();
   return std::string();
 }
 
 base::FilePath PepperFileRefHost::GetExternalPath() const {
   if (backend_)
     return backend_->GetExternalPath();
   return base::FilePath();
 }
 
-int32_t PepperFileRefHost::HasPermissions(int permissions) const {
+int32_t PepperFileRefHost::CanRead() const {
   if (backend_)
-    return backend_->HasPermissions(permissions);
+    return backend_->CanRead();
   return PP_ERROR_FAILED;
 }
 
+int32_t PepperFileRefHost::CanWrite() const {
+  if (backend_)
+    return backend_->CanWrite();
+  return PP_ERROR_FAILED;
+}
+
+int32_t PepperFileRefHost::CanCreate() const {
+  if (backend_)
+    return backend_->CanCreate();
+  return PP_ERROR_FAILED;
+}
+
 int32_t PepperFileRefHost::OnResourceMessageReceived(
     const IPC::Message& msg,
     ppapi::host::HostMessageContext* context) {
   if (!backend_)
     return PP_ERROR_FAILED;
 
   IPC_BEGIN_MESSAGE_MAP(PepperFileRefHost, msg)
     PPAPI_DISPATCH_HOST_RESOURCE_CALL(PpapiHostMsg_FileRef_MakeDirectory,
                                       OnMakeDirectory);
     PPAPI_DISPATCH_HOST_RESOURCE_CALL(PpapiHostMsg_FileRef_Touch,
@@ skipping 10 matching lines @@
     PPAPI_DISPATCH_HOST_RESOURCE_CALL_0(PpapiHostMsg_FileRef_GetAbsolutePath,
                                         OnGetAbsolutePath);
 
   IPC_END_MESSAGE_MAP()
   return PP_ERROR_FAILED;
 }
 
 int32_t PepperFileRefHost::OnMakeDirectory(
     ppapi::host::HostMessageContext* context,
     bool make_ancestors) {
-  int32_t rv = HasPermissions(fileapi::kCreateFilePermissions);
+  int32_t rv = CanCreate();
   if (rv != PP_OK)
     return rv;
   return backend_->MakeDirectory(context->MakeReplyMessageContext(),
                                  make_ancestors);
 }
 
 int32_t PepperFileRefHost::OnTouch(ppapi::host::HostMessageContext* context,
                                    PP_Time last_access_time,
                                    PP_Time last_modified_time) {
   // TODO(teravest): Change this to be kWriteFilePermissions here and in
   // fileapi_message_filter.
-  int32_t rv = HasPermissions(fileapi::kCreateFilePermissions);
+  int32_t rv = CanCreate();
   if (rv != PP_OK)
     return rv;
   return backend_->Touch(context->MakeReplyMessageContext(),
                          last_access_time,
                          last_modified_time);
 }
 
 int32_t PepperFileRefHost::OnDelete(ppapi::host::HostMessageContext* context) {
-  int32_t rv = HasPermissions(fileapi::kWriteFilePermissions);
+  int32_t rv = CanWrite();
   if (rv != PP_OK)
     return rv;
   return backend_->Delete(context->MakeReplyMessageContext());
 }
 
 int32_t PepperFileRefHost::OnRename(ppapi::host::HostMessageContext* context,
                                     PP_Resource new_file_ref) {
-  int32_t rv = HasPermissions(
-      fileapi::kReadFilePermissions | fileapi::kWriteFilePermissions);
+  int32_t rv = CanRead();
   if (rv != PP_OK)
     return rv;
 
+  rv = CanWrite();

[Tom Sepez, 2013/07/19 18:39:28]

Doesn't checking read/write separately have the effect of invoking file url
validtion twice under the covers?

[tommycli, 2013/07/23 21:12:35]

Done.

+  if (rv != PP_OK)
+    return rv;
+
   ResourceHost* resource_host =
       host_->GetPpapiHost()->GetResourceHost(new_file_ref);
   if (!resource_host)
     return PP_ERROR_BADRESOURCE;
 
   PepperFileRefHost* file_ref_host = resource_host->AsPepperFileRefHost();
   if (!file_ref_host)
     return PP_ERROR_BADRESOURCE;
 
-  rv = file_ref_host->HasPermissions(fileapi::kCreateFilePermissions);
+  rv = file_ref_host->CanCreate();
   if (rv != PP_OK)
     return rv;
 
   return backend_->Rename(context->MakeReplyMessageContext(),
                           file_ref_host);
 }
 
 int32_t PepperFileRefHost::OnQuery(ppapi::host::HostMessageContext* context) {
-  int32_t rv = HasPermissions(fileapi::kReadFilePermissions);
+  int32_t rv = CanRead();
   if (rv != PP_OK)
     return rv;
   return backend_->Query(context->MakeReplyMessageContext());
 }
 
 int32_t PepperFileRefHost::OnReadDirectoryEntries(
     ppapi::host::HostMessageContext* context) {
-  int32_t rv = HasPermissions(fileapi::kReadFilePermissions);
+  int32_t rv = CanRead();
   if (rv != PP_OK)
     return rv;
   return backend_->ReadDirectoryEntries(context->MakeReplyMessageContext());
 }
 
 int32_t PepperFileRefHost::OnGetAbsolutePath(
     ppapi::host::HostMessageContext* context) {
   if (!host_->GetPpapiHost()->permissions().HasPermission(
       ppapi::PERMISSION_PRIVATE))
     return PP_ERROR_NOACCESS;
   return backend_->GetAbsolutePath(context->MakeReplyMessageContext());
 }
 
 }  // namespace content