Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 1976963002: Reland Add V8.Execute histogram to measure time spent executing JS code. (Closed)

Created:
4 years, 7 months ago by rmcilroy
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Add V8.Execute histogram to measure time spent executing JS code. Adds a V8.Execute histogram to measure the amount of time spent executing JS code. BUG=v8:4865 LOG=N Committed: https://crrev.com/48a1c5667a0a96328ec35ecc9fb5b9906dd9c022 Cr-Commit-Position: refs/heads/master@{#36245}

Patch Set 1 #

Patch Set 2 : Make execute histogram counters nestable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -40 lines) Patch
M src/api.cc View 1 5 chunks +5 lines, -0 lines 0 comments Download
M src/counters.h View 1 chunk +42 lines, -40 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
rmcilroy
Original in PS1, fix for roll in PS2. PTAL, thanks.
4 years, 7 months ago (2016-05-13 13:50:25 UTC) #4
Camillo Bruni
lgtm
4 years, 7 months ago (2016-05-13 13:58:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976963002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976963002/60001
4 years, 7 months ago (2016-05-13 14:13:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-05-13 14:44:19 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 14:46:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48a1c5667a0a96328ec35ecc9fb5b9906dd9c022
Cr-Commit-Position: refs/heads/master@{#36245}

Powered by Google App Engine
This is Rietveld 408576698