Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 197693003: Replace --ppapi-keep-alive-throttle command line switch with IPC parameter. (Closed)

Created:
6 years, 9 months ago by scheib
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Replace --ppapi-keep-alive-throttle command line switch with IPC parameter. Part of a broad effort to reduce the number of command line switches. This is the second land of this change - correcting a static initializer issue. BUG=350510 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256961

Patch Set 1 : Patch from previous land r351620 #

Patch Set 2 : Move literal to .h to avoid static initializer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -45 lines) Patch
M chrome/browser/extensions/app_background_page_apitest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M components/nacl/browser/nacl_process_host.h View 2 chunks +6 lines, -0 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 4 chunks +13 lines, -2 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/plugin_globals.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/plugin_globals.cc View 5 chunks +8 lines, -16 lines 0 comments Download
M ppapi/proxy/plugin_main_irt.cc View 4 chunks +4 lines, -16 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/shared_impl/ppapi_constants.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppapi_nacl_plugin_args.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppapi_nacl_plugin_args.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppapi_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppapi_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scheib
Please take a look again -- the previous land included a static initializer, corrected in ...
6 years, 9 months ago (2014-03-12 18:19:38 UTC) #1
Mark Seaborn
On 2014/03/12 18:19:38, scheib wrote: > Please take a look again -- the previous land ...
6 years, 9 months ago (2014-03-12 18:25:36 UTC) #2
dmichael (off chromium)
lgtm
6 years, 9 months ago (2014-03-12 19:15:13 UTC) #3
Tom Sepez
Still LGTM.
6 years, 9 months ago (2014-03-13 18:36:45 UTC) #4
scheib
The CQ bit was checked by scheib@chromium.org
6 years, 9 months ago (2014-03-13 20:02:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/197693003/40001
6 years, 9 months ago (2014-03-13 20:09:01 UTC) #6
commit-bot: I haz the power
Change committed as 256961
6 years, 9 months ago (2014-03-14 00:07:56 UTC) #7
Nico
6 years, 9 months ago (2014-03-14 05:00:07 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/199933002/ by thakis@chromium.org.

The reason for reverting is: Broke building on
http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28x86%2...

This bot builds with disable_nacl=1 for some reason (mentioned in the stdio
above somewhere – not sure why this is), and thus chrome_browser doesn't depend
on nacl_browser, leading to this linker error when building browser_tests:

chromeos-chrome-35.0.1889.0_alpha-r1:
../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/extensions/app_background_page_apitest.cc:134:
error: undefined reference to
'nacl::NaClProcessHost::SetPpapiKeepAliveThrottleForTesting(unsigned int)'


(Maybe this change generally breaks building browser_tests with
disable_nacl=1?).

Powered by Google App Engine
This is Rietveld 408576698