Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: build/android/gyp/ant.py

Issue 197693002: [Android] Lint build/android/gyp/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: now using extra_paths_list to avoid F0401s Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/PRESUBMIT.py ('k') | build/android/gyp/apk_install.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/ant.py
diff --git a/build/android/gyp/ant.py b/build/android/gyp/ant.py
index fc1b3afbf920074dc1faeb4d0c9b5a27a725fec5..49e44bba6245188e52338ac32a309540606c18d5 100755
--- a/build/android/gyp/ant.py
+++ b/build/android/gyp/ant.py
@@ -25,20 +25,20 @@ def main(argv):
try:
args = argv[1:]
stdout = build_utils.CheckOutput(['ant'] + args)
- except build_utils.CalledProcessError as e:
+ except build_utils.CalledProcessError:
# It is very difficult to diagnose ant failures without the '-verbose'
# argument. So, when an ant command fails, re-run it with '-verbose' so that
# the cause of the failure is easier to identify.
verbose_args = ['-verbose'] + [a for a in argv[1:] if a != '-quiet']
try:
stdout = build_utils.CheckOutput(['ant'] + verbose_args)
- except build_utils.CalledProcessError as e:
+ except build_utils.CalledProcessError:
traceback.print_exc()
sys.exit(1)
# If this did sys.exit(1), building again would succeed (which would be
# awkward). Instead, just print a big warning.
- build_util.PrintBigWarning(
+ build_utils.PrintBigWarning(
'This is unexpected. `ant ' + ' '.join(args) + '` failed.' +
'But, running `ant ' + ' '.join(verbose_args) + '` passed.')
« no previous file with comments | « build/android/PRESUBMIT.py ('k') | build/android/gyp/apk_install.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698