Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: build/android/gyp/util/build_device.py

Issue 197693002: [Android] Lint build/android/gyp/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/gyp/util/build_device.py
diff --git a/build/android/gyp/util/build_device.py b/build/android/gyp/util/build_device.py
index 6870400cb5896bc65af2249eefed32d2ef6d2b77..d0bb861c984ce6fd4469124d6738dc3bda03d815 100644
--- a/build/android/gyp/util/build_device.py
+++ b/build/android/gyp/util/build_device.py
@@ -11,14 +11,14 @@ import os
import re
import sys
-import build_utils
+import build_utils # pylint: disable=F0401
BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..', '..')
sys.path.append(BUILD_ANDROID_DIR)
from pylib import android_commands
-from pylib.android_commands import GetAttachedDevices
+GetAttachedDevices = android_commands.GetAttachedDevices
class BuildDevice(object):
@@ -52,8 +52,8 @@ class BuildDevice(object):
return matches[0] if matches else None
-def GetConfigurationForDevice(id):
- adb = android_commands.AndroidCommands(id)
+def GetConfigurationForDevice(device_id):
+ adb = android_commands.AndroidCommands(device_id)
configuration = None
has_root = False
is_online = adb.IsOnline()
@@ -69,7 +69,7 @@ def GetConfigurationForDevice(id):
cmd_output = adb.RunShellCommand(cmd)
configuration = {
- 'id': id,
+ 'id': device_id,
'description': cmd_output[-1],
'install_metadata': cmd_output[:-1],
}

Powered by Google App Engine
This is Rietveld 408576698